-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RuntimeAsync] Move runtime async to the main repo #113976
Draft
VSadov
wants to merge
184
commits into
dotnet:main
Choose a base branch
from
VSadov:a2move
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actually write some "async" and start breaking things again
… and see if suspension works NOTE: No methods with generic parameters will work with the current implementation, generics may require a bunch of infrastructure work, separate from the async work
- Public apis for directly awaiting from async2 code - Update test case to use the new apis and now the code is lovely and simple
…ils into doc, but managed code may have the right logic :)
…ext as appropriate
make things build
…ably in the presence of Suspend operations, but other stuff seems to work. Now to rework Task generation to avoid multithreaded races
…t number of iterations, I think
remove DEFINE_METHOD for no longer existing methods
This was referenced Mar 28, 2025
This was referenced Mar 30, 2025
Open
This was referenced Mar 30, 2025
This was referenced Mar 31, 2025
885a2f4
to
650a7bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not review just yet. May need some work.
A list of things to address. Some of these may be more relevant to address separately later.
Required before merge:
NativeCodeVersion
/NativeCodeVersionNode
/PrepareCodeConfig
slot changes (not used in the end)auto
inClassifyAsyncMethodSignatureCore
restoreregs_for_runtimesuspension.h
ILCodeStream::EmitUNBOX
if it is unusedgetAsyncResumptionStub
should be debug-onlyClean ups that are potentially not necessary for this PR (but some of these may be nice-to-have before review):
this
in structs. Maybe ok to just have an assert/failfast instead, for now.CORINFO_HELP_THROWEXACT
in favor of usingExceptionDispatchInfo
GenTreeCall::gtIsAsyncCall
with a flag or calling convention changeget_RuntimeAsyncViaJitGeneratedStateMachines
MethodTableNative::GetLoaderAllocatorHandle
in managed codeMethodTable::GetParallelMethodDesc