-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cDAC] Remove superfluous modifiers from contract interfaces #113983
base: main
Are you sure you want to change the base?
[cDAC] Remove superfluous modifiers from contract interfaces #113983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes redundant modifiers from contract interface method declarations to adhere to modern C# practices.
- Removed explicit "public virtual" modifiers from interface members in multiple files.
- Updated method signatures across various contract interfaces for consistency.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
IStressLog.cs | Removed modifiers from interface methods. |
IStackWalk.cs | Removed redundant modifiers from interface methods. |
IRuntimeTypeSystem.cs | Removed explicit modifiers from numerous interface methods. |
IObject.cs | Removed modifiers from interface methods. |
ILoader.cs | Removed modifiers from interface methods. |
IException.cs | Removed modifiers from interface methods. |
IEcmaMetadata.cs | Removed modifiers from interface methods. |
IDacStreams.cs | Removed modifiers from interface methods. |
Comments suppressed due to low confidence (1)
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStressLog.cs:40
- [nitpick] The parameter name 'Logs' is in PascalCase; consider renaming it to 'logs' to follow typical camelCase conventions for parameter names.
IEnumerable<ThreadStressLogData> GetThreadStressLogs(TargetPointer Logs) => throw new NotImplementedException();
/azp run runtime-diagnostics |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @tommcdon |
#113769 (comment)