Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract UnsafeAccessorAttribute generation code. #113989

Merged

Conversation

AaronRobinsonMSFT
Copy link
Member

This extracts the UnsafeAccessorAttribute generator code and places it in its translation unit.

No functional changes.

This extracts the UnsafeAccessor generator code
and places it in its compilation unit.
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 10.0.0 milestone Mar 27, 2025
@Copilot Copilot bot review requested due to automatic review settings March 27, 2025 21:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/coreclr/vm/CMakeLists.txt: Language not supported

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT
Copy link
Member Author

/cc @jkoritzinsky @davidwrighton

@davidwrighton
Copy link
Member

Hmm... fyi for @VSadov as this tangentially touches on the async await work, I think you may want to follow @AaronRobinsonMSFT 's work here, and pull the async thunk logic into its own file as well. I expect it'll make things easier to review in the future. I would probably leave MethodDesc::TryGenerateTransientILImplementation in prestub.cpp and move async thunks into their own place.

@AaronRobinsonMSFT
Copy link
Member Author

/ba-g Various timeouts.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 50e6f48 into dotnet:main Mar 29, 2025
96 of 98 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the extract_unsafeaccessor_code branch March 29, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants