JIT: Fix improperly contained BroadcastScalarToVector(CreateScalar(GT_LONG)) #113994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
saucecontrol
changed the title
This was referenced Mar 28, 2025
|
@BruceForstall, PTAL. |
|
Last commit adds a second fix for this issue. Either works in isolation, but this resolves the broken pattern from two sides.
|
|
/azp run runtime-coreclr superpmi-diffs |
BruceForstall
approved these changes
Mar 31, 2025
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g azure linux 3 timeouts |
thaystg
pushed a commit
to thaystg/runtime
that referenced
this pull request
Apr 1, 2025
…_LONG)) (dotnet#113994) * fix improperly contained CreateScalar * add check for BroadcastScalarToVector(CreateScalar())
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113832 (comment)
This was another case where
CreateScalar([GT_LONG])was improperly assumed to be containable in a broadcast, which in turn allowed the broadcast to be contained in another instruction as an EVEX embedded broadcast. It was assumed that if theCreateScalarcontained its operand, it was a memory load, and a broadcast could peek through to the memory operand.