Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] [hotreload] Adjust row_size and size_bitfield from the baseline based on the delta sizes #113995

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[mono] [hotreload] Adjust row_size and size_bitfield from the baseline based on the delta sizes #113995

wants to merge 4 commits into from
+60 −40

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Mar 28, 2025

Fix applying hot reload changes when the delta table has a bigger len than the baseline table.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2396448

Copilot
Copilot AI reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/mono/mono/component/hot_reload.c: Language not supported

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc label Mar 28, 2025
This was referenced Mar 28, 2025
Open
Open
Open
Open
@lewing
Copy link
Member

lewing commented Mar 29, 2025

failures are unrelated. can we add a test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@lewing lewing Awaiting requested review from lewing

@lambdageek lambdageek Awaiting requested review from lambdageek

@tommcdon tommcdon Awaiting requested review from tommcdon

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@thaystg thaystg

Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thaystg @lewing