Skip to content

[S.T.J] Removed unused field in JsonProperty #114071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025
Merged

[S.T.J] Removed unused field in JsonProperty #114071

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddea2aa
Removed unused field in JsonProperty (#113643)
Mar 31, 2025
7c61a07
Merge branch 'main' into 113643-jsonproperty-remove-unused-field
eiriktsarpalis Apr 7, 2025
72fd730
Merge branch 'main' into 113643-jsonproperty-remove-unused-field
eiriktsarpalis Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonProperty.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ public readonly struct JsonProperty
/// The value of this property.
/// </summary>
public JsonElement Value { get; }
private string? _name { get; }

internal JsonProperty(JsonElement value)
{
Expand All @@ -25,8 +24,9 @@ internal JsonProperty(JsonElement value)

/// <summary>
/// The name of this property.
/// This allocates a new string instance for each call.
/// </summary>
public string Name => _name ?? Value.GetPropertyName();
public string Name => Value.GetPropertyName();

/// <summary>
/// Compares <paramref name="text" /> to the name of this property.
Expand Down Expand Up @@ -116,15 +116,7 @@ public void WriteTo(Utf8JsonWriter writer)
{
ArgumentNullException.ThrowIfNull(writer);

if (_name is null)
{
Value.WritePropertyNameTo(writer);
}
else
{
writer.WritePropertyName(_name);
}

Value.WritePropertyNameTo(writer);
Value.WriteTo(writer);
}

Expand Down
Loading