[draft] Trim ActivitySource via System.Diagnostics.ActivitySource.IsSupported feature #114636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
This was referenced Apr 14, 2025
jkotas
reviewed
Apr 15, 2025
...braries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncMethodBuilderCore.cs
Outdated
Show resolved
Hide resolved
pavelsavara
added
size-reduction
|
Tagging subscribers to this area: @tommcdon |
- MSBuild property ActivitySourceSupport
This was referenced Apr 15, 2025
pavelsavara
changed the title
jkotas
reviewed
Apr 16, 2025
src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionTelemetry.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 16, 2025
src/libraries/System.Net.Security/src/System/Net/Security/NetSecurityTelemetry.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Apr 17, 2025
| @@ -453,7 +451,14 @@ public IEnumerable<ActivityLink> Links | |||
| /// <param name="operationName">Operation's name <see cref="OperationName"/></param> | |||
| public Activity(string operationName) | |||
| { | |||
| Source = s_defaultSource; | |||
| if (!ActivitySource.IsSupported) | |||
There was a problem hiding this comment.
Why does the linker see the Activity as instantiated so that you have to do this manually?
There was a problem hiding this comment.
regex /e=".*System.Diagnostics.Activity:: on artifacts\bin\trimmingTests\projects\System.Net.Http.TrimmingTests\DiagnosticsAndMetricsTrimmedTest\win-x64\obj\Release\net10.0\win-x64\linked\linker-dependencies.xml can find 34 member usages. Maybe this is not one of them and I was too defensive.
There was a problem hiding this comment.
I sent you the file in Teams
# Conflicts: # src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs
This was referenced Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Diagnostics.ActivitySource.IsSupportedContribute to #114635
On top of #114326