Skip to content

Fixes grammar in comments for Gen2GcCallback.cs #114674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kamronbatman
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 15, 2025 06:29
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 15, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 15, 2025
@MihaZupan
Copy link
Member

The existing comment looks more correct to me.
You aren't talking about a single callback invocation, but about the same callback being invoked over and over again.
Hence the chain of callbacks stops, not that a single callback stops.

@kamronbatman
Copy link
Contributor Author

kamronbatman commented Apr 15, 2025

The existing comment looks more correct to me. You aren't talking about a single callback invocation, but about the same callback being invoked over and over again. Hence the chain of callbacks stops, not that a single callback stops.

I'll be happy to revert that part. I think the a to an still makes sense. I know it's a super minor nit of a change.

@kamronbatman
Copy link
Contributor Author

@MihaZupan - reverted the change you were talking about and left the two a -> an changes. Should be good to go?

Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

@MihaZupan
Copy link
Member

This seems to be a more common typo: https://grep.app/search?f.repo=dotnet%2Fruntime&f.repo.pattern=runtime&regexp=true&q=%5B%5Ea-z%5Da+object
Mind find-replaceing all of them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-GC-coreclr community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants