-
Notifications
You must be signed in to change notification settings - Fork 5k
JIT: Fix handling for SIMD types in async transformation #115652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes SIMD type handling in the JIT async transformation, updates test warning suppression, and adds debug-phase tracking.
- Replace block indirections/stores with load/store value nodes for struct and SIMD types in async.cpp.
- Centralize CS1998 warning suppression in Directory.Build.props and remove per-file pragmas.
- Add a debug-only assignment to record the “most recently active” async phase.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/tests/async/pgo/pgo.cs | Removed local #pragma warning disable CS1998 . |
src/tests/async/mincallcost-microbench/mincallcost-microbench.cs | Removed local #pragma warning disable CS1998 . |
src/tests/async/fibonacci-without-yields-config-await/fibonacci-without-yields-config-await.cs | Removed local #pragma warning disable CS1998 comment. |
src/tests/async/Directory.Build.props | Added CS1998 to global NoWarn to suppress warnings. |
src/coreclr/jit/async.cpp | Switched gtNewBlkIndir /gtNewStoreBlkNode to gtNewLoadValueNode /gtNewStoreValueNode , updated assert, and added INDEBUG phase tracking. |
cc @dotnet/jit-contrib PTAL @AndyAyersMS Also disable the "method lacks |
Fix #115613