-
Notifications
You must be signed in to change notification settings - Fork 5k
MSBUILD Server dogfood #115766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MSBUILD Server dogfood #115766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables the MSBuild server feature in CI by setting the MSBUILDUSESERVER
variable.
- Introduces a new pipeline variable to dogfood the MSBuild server
- Enables internal rollout for AspNetCore builds
Comments suppressed due to low confidence (1)
eng/pipelines/common/variables.yml:47
- [nitpick] The variable name is in all-caps without separators; consider using a consistent naming style (e.g., camelCase or kebab-case) to match other pipeline variables.
name: MSBUILDUSESERVER
Note: I'm not familiar with your pipelines. Turning on MSBUILD server is done via setting the environment variable MSBUILSUSESERVER to 1 so that is what I was trying to achieve. While checking the binlog of the failed check it claims that MSBUILDUSESERVER=0 so I probably placed the variable at a wrong spot. |
@jkoritzinsky where's the best place to set an env var in runtime's YML that should impact all msbuild invocations? |
I'd put it in global-build-step.yml. That will catch almost all product builds (not runtime tests). |
90e63a3
to
55d4574
Compare
MSBUILD Server dogfood
Part of #9379
Please help us with our dofgooding effort for the MSBuild server feature.
For now we've dogfooded internally for our pipelines, we're running without issues within Aspnetcore and we would like to continue the rollout before we're confident enough to make Server build the new default.