Fix typo in RecognizerBase: invalid variable in condition #115902
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
needs-area-label
This was referenced May 23, 2025
Open
stephentoub
approved these changes
May 28, 2025
There was a problem hiding this comment.
Thanks. It's a little concerning that this hasn't manifested before; that suggests it's likely that every non-null eventData is a SpeechEvent. There's the possibility that other things were coming in, triggering null ref exceptions here, and those were being eaten somewhere higher up, in which case this could now start exercising behavior that wasn't previously invoked or invoked in the same circumstance. But the current code is obviously wrong, and tests are passing, so I think it's worth fixing. Hopefully it's actually the case that this never manifested as a problem because all non-null eventDatas are already SpeechEvents.
|
/ba-g test failures are not relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by Linux Verification Center (linuxtesting.org) with SVACE.