Bring back the reader-writer lock for RcwCache #120675
Open
+49
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of writing to
_cache
while under a reader lock, delay the cleanup until we can acquire a writer lock.We do this instead of doing an upgradeable lock as
ReaderWriterLockSlim
only supports one upgradeable reader thread at a time, removing the benefit of having an rwlock in the first place.This matches the logic in the .NET 9 CoreCLR implementation of ComWrappers.
Reverts #120370
Fixes #120470