[browser] rename internal JSImports to camelCase #122231
Merged
+74
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
This was referenced Dec 5, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames internal JavaScript import functions from snake_case to camelCase convention, improving naming consistency across the browser WebAssembly runtime. The changes affect the TypeScript export definitions and all corresponding C# JSImport attribute declarations.
- Updates TypeScript exports in
exports-internal.tsto use camelCase naming - Updates all C# JSImport declarations to match the new TypeScript export names
- Covers interop functions, WebSocket operations, and HTTP handler functions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mono/browser/runtime/exports-internal.ts | Renames TypeScript exports from snake_case to camelCase (e.g., get_property → getProperty, ws_wasm_create → wsCreate, http_wasm_fetch → httpFetch) |
| src/libraries/System.Runtime.InteropServices.JavaScript/tests/System.Runtime.InteropServices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/Utils.cs | Updates test utility JSImport declarations to use new camelCase names for setProperty and getProperty |
| src/libraries/System.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptImports.Generated.cs | Updates all core JavaScript interop JSImport declarations to use camelCase names |
| src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserInterop.cs | Updates WebSocket-related JSImport declarations to use new camelCase names (e.g., wsCreate, wsOpen, wsSend) |
| src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpInterop.cs | Updates HTTP handler JSImport declarations to use new camelCase names (e.g., httpFetch, httpSupportsStreamingRequest) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #120703