Rename SVE2 AddSaturate signed/unsigned addend API #122283
Open
+130
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename Sve2.AddSaturateWithUnsignedAddend/AddSaturateWithSignedAddend to Sve2.AddSaturate so that it aligns with the approved SVE2 API.
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121961.
Rename
Sve2.AddSaturateWithUnsignedAddend/AddSaturateWithSignedAddendtoSve2.AddSaturateso that it aligns with the approved SVE2 API.Since the Sve2.AddSaturate intrinsic is used for multiple instructions, special intrinsics are used internally for the signed/unsigned addend variants. The AddSaturate intrinsic is marked with the SpecialImport flag so that the actual instruction can be decided based on the operand types during importing.
@dotnet/arm64-contrib @a74nh