Mark async reflection tests relying on stack frames as NoInlining #123345
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FromStack(1)` and `FromStackDMI(1)` rely on the test entry points to not be inlined into the test executor, so ensure these are NoInlining.
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes flaky async reflection tests by adding NoInlining attributes to test entry points that depend on specific stack frame information. When these tests are inlined by the test executor, the StackFrame constructor with level=1 parameter would skip the wrong frame, causing test failures.
Changes:
- Added
[MethodImpl(MethodImplOptions.NoInlining)]to theFromStacktest method - Added
[MethodImpl(MethodImplOptions.NoInlining)]to theFromStackDMItest method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FromStack(1)andFromStackDMI(1)rely on the test entry points to not be inlined into the test executor, so ensure these are NoInlining.Fix #123279