Fix interpreting baud rate bitmask as decimal value #123348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(obtained from user).
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
Author
|
@dotnet-policy-service agree company="Microsoft" |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where baud rate bitmask values from Windows drivers were being incorrectly interpreted as decimal values, causing validation errors. Some device drivers (like Silicon Labs USB to UART converters) return a decimal baud rate value instead of a bitmask, while Windows documentation specifies bitmasks should be used.
Changes:
- Added a new helper method
ConvertMaxBaudBitMaskToBaudRateto intelligently interpret thedwMaxBaudfield as either a bitmask or decimal value - Updated the BaudRate property setter to use the converted value for validation
- Updated the SerialStream constructor to use the converted value for validation
src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.Windows.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.Windows.cs
Show resolved
Hide resolved
src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.Windows.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.Windows.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Ports/src/System/IO/Ports/SerialStream.Windows.cs
Outdated
Show resolved
Hide resolved
huoyaoyuan
added
area-System.IO.Ports
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io-ports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to fix !119105.