Skip to content

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991675#128945

Open
dotnet-bot wants to merge 3 commits into
mainfrom
locfiles/992c44bf-c37e-4d49-b092-49e23ce1488c
Open

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991675#128945
dotnet-bot wants to merge 3 commits into
mainfrom
locfiles/992c44bf-c37e-4d49-b092-49e23ce1488c

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@github-actions

This comment has been minimized.

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991229 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991253 Jun 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

🤖 Copilot Code Review — PR #128945

Holistic Assessment

Motivation: This is an automated localization check-in by the OneLocBuild pipeline. It updates .xlf translation files for System.Text.Json and Microsoft.Extensions.Logging.Abstractions source generators across 13 language locales. This is a standard, well-established process in dotnet/runtime.

Approach: The PR contains 3 commits from the OneLocBuild task. Commit 1 (Build 2991229) removed some translation entries and added new state="new" entries. Commits 2 and 3 (Build 2991253) restored/updated the translations for the logging and JSON libraries respectively. The net effect is updated translations for new source strings (Union-related diagnostics in System.Text.Json, updated logging diagnostics).

Summary: ✅ LGTM. This is a routine automated localization PR. All 26 changed files are .xlf translation resource files — no source code, no API surface changes, no behavioral changes. The translations follow the established XLF format and structure.


Detailed Findings

✅ File Scope — Translation files only

All changes are confined to *.xlf files under gen/Resources/xlf/ directories for two libraries:

  • src/libraries/System.Text.Json/gen/Resources/xlf/Strings.*.xlf (13 locales)
  • src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.*.xlf (13 locales)

No source code, tests, project files, or public API surface is affected.

✅ XLF Structure — Consistent format

The translation entries follow the standard XLIFF 1.2 format with proper <source>, <target state="translated">, and <note /> elements. New entries for Union-related diagnostics (UnionCaseTypesNotClassifiable*, UnionTypeShapeNotSupported*) and updated logging entries are properly structured.

✅ No Security or Correctness Concerns

Localization-only changes carry no risk of behavioral regression, security issues, or breaking changes.

Note

🔒 Integrity filter blocked 1 item

The following item was blocked because it doesn't meet the GitHub integrity level.

  • bbad0bb list_commits: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Code Review for issue #128945 · ● 2.1M ·

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991253 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991337 Jun 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991337 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991398 Jun 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991398 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991423 Jun 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991423 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991488 Jun 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991488 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991574 Jun 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991574 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2991675 Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant