JIT: Fix assertion failed 'genActualType(cmp->gtGetOp1()) == genActualType(cmp->gtGetOp2())'

[BoyBaykiller]

Fix #128947

This assert is not a function specific assumption, rather a general IR validation - to my understanding.
The function uses the supportedOp lambda to actually cull out unsupported/uninteresting comparisons.
So it should be fine to change it.

The existing assert fired when seeing EQ(byref, long), for example:

*  NE        int   
+--*  LCL_VAR   byref  V01 arg1         
\--*  CAST      long <- ulong <- uint
   \--*  CNS_INT   int    0

Because it only considers genActualType(cmp->gtGetOp1()) == genActualType(cmp->gtGetOp2()) legal.

I don't really know what we consider legal IR and there is no centralized place so as a fix I copied this existing assert from importer:

runtime/src/coreclr/jit/importer.cpp

Lines 7937 to 7938 in b0f76ec

	assertImp((genActualType(op1) == genActualType(op2)) || (varTypeIsI(op1) && varTypeIsI(op2)) ||
	(varTypeIsFloating(op1) && varTypeIsFloating(op2)));

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[BoyBaykiller]

@EgorBo PTAL.

[EgorBo]

Thanks