JIT: Refactor optOptimizeBoolsCondBlock to be table-driven#128964
Open
EgorBo wants to merge 3 commits into
Open
JIT: Refactor optOptimizeBoolsCondBlock to be table-driven#128964EgorBo wants to merge 3 commits into
EgorBo wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the CoreCLR JIT boolean-conditional folding logic in OptBoolsDsc::optOptimizeBoolsCondBlock by replacing a nested if/else cascade with a small rule table and lookup, along with several small cleanups in the same compilation unit.
Changes:
- Introduces a table-driven matcher (
OptBoolsRule+s_optBoolsRules) to select(foldOp, cmpOp)based on adjacentBBJ_CONDblock patterns, including a normalization step to reuse the same table for bothm_sameTargetcases. - Replaces ad-hoc debug printing with existing
JITDUMP/DISPSTMTmacros in the modified optimization path(s). - Performs small cleanups in
optimizebools.cpp(e.g., log prefix fix, local cleanup, minor boolean/const handling tweaks).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
OptBoolsDsc::optOptimizeBoolsCondBlockfrom a long if/else cascade into a small table-driven matcher, plus a few drive-by cleanups in the same file.