-
Notifications
You must be signed in to change notification settings - Fork 5k
Use pattern value in the summary for the generated regex method. #96488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsFixes #94760
|
OK, so we're failing the tests with special chars that are not valid XML chars in the pattern, such as 0x00 and 0xFFFF. I think we should use the Regex escape syntax ( |
The current logic is not quite correct for |
…ing rawstring for the pattern argument as the value is environment specific.
Wrong direction. As the |
Thanks, anyway, for your efforts. |
@stephentoub You're welcome. It's a good lesson for me to know the Regex better. |
Fixes #94760