Skip to content

Add AOT test for CopyOutputSymbolsToPublishDirectory #35593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agocke wants to merge 2 commits into from
Closed

Add AOT test for CopyOutputSymbolsToPublishDirectory #35593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62b0a4d
Add AOT test for CopyOutputSymbolsToPublishDirectory
agocke Sep 20, 2023
c5d0c2d
Remove unnecessary RequiresMSBuildVersion
agocke Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 53 additions & 24 deletions src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public GivenThatWeWantToPublishAnAotApp(ITestOutputHelper log) : base(log)
{
}

[RequiresMSBuildVersionTheory("17.8.0")]
[Theory]
[MemberData(nameof(Net7Plus), MemberType = typeof(PublishTestUtils))]
public void NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled(string targetFramework)
{
Expand Down Expand Up @@ -72,7 +72,36 @@ public void NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled(string
.And.HaveStdOutContaining("Hello World");
}

[RequiresMSBuildVersionTheory("17.8.0")]
[Fact]
public void NoCopyOutputSymbolsToPublishDirectory()
{
var targetFramework = ToolsetInfo.CurrentTargetFramework;
var projectName = "HellowWorldNativeAotApp";
var rid = EnvironmentInfo.GetCompatibleRid(targetFramework);

var testProject = CreateHelloWorldTestProject(targetFramework, projectName, true);
testProject.AdditionalProperties["PublishAot"] = "true";
testProject.AdditionalProperties["CopyOutputSymbolsToPublishDirectory"] = "false";
var testAsset = _testAssetsManager.CreateTestProject(testProject);

var publishCommand = new PublishCommand(testAsset);
publishCommand
.Execute($"/p:RuntimeIdentifier={rid}", "/p:SelfContained=true")
.Should().Pass();

var publishDirectory = publishCommand.GetOutputDirectory(targetFramework: targetFramework, runtimeIdentifier: rid).FullName;
var publishedExe = Path.Combine(publishDirectory, $"{testProject.Name}{Constants.ExeSuffix}");

var command = new RunExeCommand(Log, publishedExe)
.Execute().Should().Pass()
.And.HaveStdOutContaining("Hello World");

// No Symbols in publish directory
DoSymbolsExist(publishDirectory, testProject.Name).Should().BeFalse();
IsNativeImage(publishedExe).Should().BeTrue();
}

[Theory]
[MemberData(nameof(Net7Plus), MemberType = typeof(PublishTestUtils))]
public void NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_false(string targetFramework)
{
Expand Down Expand Up @@ -107,7 +136,7 @@ public void NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_false(string t
}
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void NativeAot_app_runs_in_debug_with_no_config_when_PublishAot_is_enabled(string targetFramework)
{
Expand Down Expand Up @@ -160,7 +189,7 @@ public void NativeAot_app_runs_in_debug_with_no_config_when_PublishAot_is_enable
.Execute().Should().Pass();
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void NativeAot_app_runs_in_release_with_no_config_when_PublishAot_is_enabled(string targetFramework)
{
Expand Down Expand Up @@ -212,7 +241,7 @@ public void NativeAot_app_runs_in_release_with_no_config_when_PublishAot_is_enab
.Execute().Should().Pass();
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void NativeAot_app_builds_with_config_when_PublishAot_is_enabled(string targetFramework)
{
Expand Down Expand Up @@ -246,7 +275,7 @@ public void NativeAot_app_builds_with_config_when_PublishAot_is_enabled(string t
File.Exists(depsPath).Should().BeTrue();
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void NativeAot_hw_runs_with_PackageReference_PublishAot_is_enabled(string targetFramework)
{
Expand Down Expand Up @@ -302,7 +331,7 @@ public void NativeAot_hw_runs_with_PackageReference_PublishAot_is_enabled(string
CheckIlcVersions(testAsset, targetFramework, rid, ExplicitPackageVersion);
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void NativeAot_hw_runs_with_PackageReference_PublishAot_is_empty(string targetFramework)
{
Expand Down Expand Up @@ -339,7 +368,7 @@ public void NativeAot_hw_runs_with_PackageReference_PublishAot_is_empty(string t
.And.HaveStdOutContaining("Hello World");
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[MemberData(nameof(Net7Plus), MemberType = typeof(PublishTestUtils))]
public void NativeAot_hw_runs_with_cross_target_PublishAot_is_enabled(string targetFramework)
{
Expand Down Expand Up @@ -369,7 +398,7 @@ public void NativeAot_hw_runs_with_cross_target_PublishAot_is_enabled(string tar
}


[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[MemberData(nameof(Net7Plus), MemberType = typeof(PublishTestUtils))]
public void NativeAot_hw_runs_with_cross_PackageReference_PublishAot_is_enabled(string targetFramework)
{
Expand Down Expand Up @@ -405,7 +434,7 @@ public void NativeAot_hw_runs_with_cross_PackageReference_PublishAot_is_enabled(
}
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void NativeAot_hw_runs_with_cross_PackageReference_PublishAot_is_empty(string targetFramework)
{
Expand Down Expand Up @@ -434,7 +463,7 @@ public void NativeAot_hw_runs_with_cross_PackageReference_PublishAot_is_empty(st
}
}

[RequiresMSBuildVersionFact("17.0.0.32901")]
[Fact]
public void NativeAot_hw_fails_with_sdk6_PublishAot_is_enabled()
{
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
Expand All @@ -454,7 +483,7 @@ public void NativeAot_hw_fails_with_sdk6_PublishAot_is_enabled()
}
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void NativeAot_hw_fails_with_sdk6_PackageReference_PublishAot_is_enabled(string targetFramework)
{
Expand All @@ -478,7 +507,7 @@ public void NativeAot_hw_fails_with_sdk6_PackageReference_PublishAot_is_enabled(
}
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void NativeAot_hw_fails_with_unsupported_target_rid(string targetFramework)
{
Expand All @@ -502,7 +531,7 @@ public void NativeAot_hw_fails_with_unsupported_target_rid(string targetFramewor
}
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void NativeAot_hw_fails_with_unsupported_host_rid(string targetFramework)
{
Expand Down Expand Up @@ -534,7 +563,7 @@ private void OverrideKnownILCompilerPackRuntimeIdentifiers(XDocument project, st
new XElement(ns + "ILCompilerRuntimeIdentifiers", runtimeIdentifiers))));
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void Only_Aot_warnings_are_produced_if_EnableAotAnalyzer_is_set(string targetFramework)
{
Expand All @@ -556,7 +585,7 @@ public void Only_Aot_warnings_are_produced_if_EnableAotAnalyzer_is_set(string ta
.And.NotHaveStdOutContaining("warning IL3002");
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void IsAotCompatible_implies_enable_analyzers(string targetFramework)
{
Expand Down Expand Up @@ -590,7 +619,7 @@ public void IsAotCompatible_implies_enable_analyzers(string targetFramework)
.And.NotHaveStdOutContaining("warning IL3002");
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData("netstandard2.0")]
public void IsAotCompatible_warns_for_unsupported_target_framework(string targetFramework)
{
Expand All @@ -611,7 +640,7 @@ public void IsAotCompatible_warns_for_unsupported_target_framework(string target
.And.HaveStdOutContaining("warning NETSDK1210");
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void Requires_analyzers_produce_warnings_without_PublishAot_being_set(string targetFramework)
{
Expand All @@ -637,7 +666,7 @@ public void Requires_analyzers_produce_warnings_without_PublishAot_being_set(str
.And.HaveStdOutContaining("warning IL3002");
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[MemberData(nameof(Net7Plus), MemberType = typeof(PublishTestUtils))]
public void NativeAot_compiler_runs_when_PublishAot_is_enabled(string targetFramework)
{
Expand Down Expand Up @@ -681,7 +710,7 @@ public void NativeAot_compiler_runs_when_PublishAot_is_enabled(string targetFram
.And.HaveStdOutContaining("Hello world");
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void Warnings_are_generated_even_with_analyzers_disabled(string targetFramework)
{
Expand Down Expand Up @@ -722,7 +751,7 @@ public void Warnings_are_generated_even_with_analyzers_disabled(string targetFra
.And.HaveStdOutContaining("Hello world");
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void NativeAotStaticLib_only_runs_when_switch_is_enabled(string targetFramework)
{
Expand Down Expand Up @@ -778,7 +807,7 @@ public void NativeAotLib_warns_when_eventpipe_is_enabled(string libType)
// .And.HaveStdOutContaining("EventSource is not supported or recommended when compiling to a native library");
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void NativeAotSharedLib_only_runs_when_switch_is_enabled(string targetFramework)
{
Expand Down Expand Up @@ -808,7 +837,7 @@ public void NativeAotSharedLib_only_runs_when_switch_is_enabled(string targetFra
IsNativeImage(publishedDll).Should().BeTrue();
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void It_publishes_with_implicit_rid_with_NativeAotApp(string targetFramework)
{
Expand All @@ -824,7 +853,7 @@ public void It_publishes_with_implicit_rid_with_NativeAotApp(string targetFramew
.Pass();
}

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[Theory]
[InlineData(ToolsetInfo.CurrentTargetFramework)]
public void It_builds_with_dynamiccodesupport_false_when_publishaot_true(string targetFramework)
{
Expand Down