Skip to content

[release/9.0.1xx] [Static web assets] Reduce allocations on DefineStaticWebAssetEndpoints #43099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 29, 2024

Backport of #43038 to release/9.0.1xx

/cc @javiercn

Reduce allocations during the Evaluation phase in VS as well as during DefineStaticWebAssetEndpoints.

Description

  • A large item group defined in the SDK was causing excessive glob evaluation.
  • We moved the majority of the definitions in that item group into the task that uses them as a set of defaults.
  • This removes the majority of the evaluations (~90%), removing the need to evaluate a large set of items.

Fixes 2164225

Customer Impact

Excessive allocations in large solutions require more memory, introducing more frequent GC pauses in Visual Studio, slowing down interaction.

Regression?

  • Yes
  • No

8.0.xxx

Risk

  • High
  • Medium
  • Low

There are lots of automated tests that make sure we haven't regressed any existing scenario with the fix.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

Sorry, something went wrong.

@github-actions github-actions bot requested review from a team as code owners August 29, 2024 21:58
@ghost ghost added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Aug 29, 2024
Copy link
Contributor

Thanks for your PR, @github-actions[bot].
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@javiercn javiercn force-pushed the backport/pr-43038-to-release/9.0.1xx branch from 3f21d72 to 2eec5d7 Compare August 30, 2024 17:31
@rbhanda rbhanda added this to the 8.0.10 milestone Sep 3, 2024
@rbhanda rbhanda modified the milestones: 8.0.10, 9.0.1xx Sep 3, 2024
@marcpopMSFT
Copy link
Member

@javiercn @MackinnonBuck you can merge whenever though the file list is different then main so may want to check that.

@javiercn
Copy link
Member

javiercn commented Sep 4, 2024

@marcpopMSFT Yes, we missed a typo in the original PR and addressed it on a follow up PR. So we just cherry-picked the commit from the follow up.

@javiercn javiercn enabled auto-merge (rebase) September 9, 2024 12:34
@javiercn javiercn force-pushed the backport/pr-43038-to-release/9.0.1xx branch from 2eec5d7 to 57230fd Compare September 9, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch Servicing-approved untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants