-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[release/9.0.1xx] Workloads: Support VS component IDs #44198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/9.0.1xx
Are you sure you want to change the base?
[release/9.0.1xx] Workloads: Support VS component IDs #44198
Conversation
@dsplaisted I modified the
I made this a configurable option in case turning it on by default impacted other tests. Seemed like the less intrusive option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I can't see all the consequences of this change.
Thanks, I'll be doing some testing on this build and setting up a project that injects additional, non-existing workloads to see how VS responds. |
src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/WorkloadId.cs
Outdated
Show resolved
Hide resolved
…dId.cs Co-authored-by: Daniel Plaisted <[email protected]>
Description
Visual Studio publishes a component catalog for extension developers. .NET option workloads do not currently follow the naming convention.
WorkloadId
struct to ensure a single source of truth.ShowMissingWorkloads
task will setVisualStudioComponentId
to use the new component prefix. 'VisualStudioComponentIds` will include the old and new component IDswasm-tools-net8
to the set of known workload IDs.Testing
Additional unit tests to verify the changes to
WorkloadId
. Previous changes fordotnet workload list
continue to return the expected results. Will likely require additional validation once we have a build with all the workload changes and the CLI with this change inserted into the same VS.Risk
Low - if WASM/Maui does not switch to using the new workload IDs it may degrade the IPA experience.