Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set RestoreConfigFile in environment #46101

Closed
wants to merge 4 commits into from
Closed

Do not set RestoreConfigFile in environment #46101

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22477e5
Do not set RestoreConfigFile in environment
mmitche Jan 17, 2025
beb7b3c
Add restore config file param for aspnetcore
mmitche Jan 22, 2025
a243ab8
Add fsharp restore config file patch
mmitche Jan 22, 2025
9709883
Add RestoreConfigFile parameter to patch
mmitche Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/SourceBuild/content/repo-projects/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,6 @@

<!-- Need to be passed in as an env var so that custom Exec tasks in the repo's DotNetBuild.props receive this setting. -->
<EnvironmentVariables Include="DotNetPackageVersionPropsPath=$(PackageVersionPropsPath)" />

<!-- Needed for miscellanous projects in various repos - see https://github.com/dotnet/source-build/issues/4081-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What has changed to address dotnet/source-build#4081?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing yet. This PR was essentially to go find the places that need alteration.

<EnvironmentVariables Include="RestoreConfigFile=$(NuGetConfigFile)" Condition="'$(NuGetConfigFile)' != ''" />
</ItemGroup>

<ItemGroup Condition="'$(DotNetBuildSourceOnly)' == 'true'">
Expand Down
Loading