Improve AssemblySymbolLoader logging #46102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-ApiCompat
untriaged
ViktorHofer
force-pushed
the
ImproveAssemblySymbolLoaderLogging
branch
from
3f9e7ac to
a79f767
Compare
ViktorHofer
force-pushed
the
ImproveAssemblySymbolLoaderLogging
branch
from
a79f767 to
b433930
Compare
ViktorHofer
force-pushed
the
ImproveAssemblySymbolLoaderLogging
branch
from
b433930 to
fb1e859
Compare
This was referenced Jan 20, 2025
akoeplinger
approved these changes
Jan 20, 2025
| } | ||
|
|
||
| return metadataReference; | ||
| } | ||
|
|
||
| private MetadataReference CreateAndAddReferenceToCompilation(string name, Stream fileStream, ImmutableHashSet<string>? referenceAssemblyNamesToIgnore = null) | ||
| private MetadataReference CreateAndAddReferenceToCompilation(string assemblyName, string rootAssemblyDisplayString, Stream fileStream, ImmutableHashSet<string>? referenceAssemblyNamesToIgnore = null, string? referenceeAssemblyName = null) |
There was a problem hiding this comment.
typo:
Suggested change
| private MetadataReference CreateAndAddReferenceToCompilation(string assemblyName, string rootAssemblyDisplayString, Stream fileStream, ImmutableHashSet<string>? referenceAssemblyNamesToIgnore = null, string? referenceeAssemblyName = null) | |
| private MetadataReference CreateAndAddReferenceToCompilation(string assemblyName, string rootAssemblyDisplayString, Stream fileStream, ImmutableHashSet<string>? referenceAssemblyNamesToIgnore = null, string? referenceAssemblyName = null) |
| _cSharpCompilation = _cSharpCompilation.AddReferences([ metadataReference ]); | ||
|
|
||
| if (referenceeAssemblyName is null) |
There was a problem hiding this comment.
Suggested change
| if (referenceeAssemblyName is null) | |
| if (referenceAssemblyName is null) |
| } | ||
| else | ||
| { | ||
| _log.LogMessage(MessageImportance.Low, string.Format(Resources.AssemblyReferenceLoaded, assemblyName, referenceeAssemblyName)); |
There was a problem hiding this comment.
Suggested change
| _log.LogMessage(MessageImportance.Low, string.Format(Resources.AssemblyReferenceLoaded, assemblyName, referenceeAssemblyName)); | |
| _log.LogMessage(MessageImportance.Low, string.Format(Resources.AssemblyReferenceLoaded, assemblyName, referenceAssemblyName)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46093
Also update the test to not assert on a an English string. Example loggings with these changes: