Support msbuild params in dotnet test #46562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-dotnet test
untriaged
MarcoRossignoli
approved these changes
Feb 5, 2025
|
I still need to add a couple of integration tests. |
…est' of https://github.com/dotnet/sdk into dev/mabdullah/support-msbuild-params-option-in-dotnet-test
MarcoRossignoli
approved these changes
Feb 6, 2025
mariam-abdulla
deleted the
dev/mabdullah/support-msbuild-params-option-in-dotnet-test
branch
This was referenced Feb 6, 2025
MiYanni
reviewed
Apr 9, 2025
| @@ -57,6 +57,7 @@ | |||
| <Compile Include="..\Microsoft.DotNet.Configurer.UnitTests\**\*.cs" LinkBase="Configurer" /> | |||
| <Compile Include="..\Microsoft.DotNet.ShellShim.Tests\**\*.cs" LinkBase="ShellShim" /> | |||
| <Compile Remove="..\dotnet-test.Tests\GivenDotnetTestBuildsAndRunsHelp.cs" /> | |||
| <Compile Remove="..\dotnet-test.Tests\MSBuildHandlerTests.cs" /> | |||
There was a problem hiding this comment.
Why were the MSBuildHandlerTests.cs tests removed? I'm cleaning up the dotnet.Tests project and related test folder structure.
There was a problem hiding this comment.
The file won't work as-is. I've made a lot of changes around the CLI and now around test projects. This is the PR for which I was referring: #48280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
dotnet-testcommand to refactor and simplify the codebase. The most important changes involve the introduction of a newPathOptionsrecord, modifications to theBuildOptionsrecord, and updates to various methods to use these new structures. Additionally, some redundant methods and imports have been removed.Refactoring and simplification:
PathOptionsrecord and updatedBuildOptionsto includePathOptionsinstead of individual path properties. (src/Cli/dotnet/commands/dotnet-test/Options.cs)RunMSBuildmethod to usePathOptionsfor path properties. (src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs)GetProjectsmethod to simplify build and restore logic by combining MSBuild arguments. (src/Cli/dotnet/commands/dotnet-test/MSBuildUtility.cs) [1] [2]IsBinaryLoggerEnabled,GetBuildParameters, andGetCommands. (src/Cli/dotnet/commands/dotnet-test/MSBuildUtility.cs) [1] [2] [3]Command and option updates:
NoRestoreOptionandNoBuildOptionto use common options and forwarding functions. (src/Cli/dotnet/commands/dotnet-test/TestCommandParser.cs,src/Cli/dotnet/commands/dotnet-test/TestingPlatformOptions.cs) [1] [2]GetTestOptionsandGetBuildOptionsto utilize newPathOptionsand handle MSBuild arguments. (src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs) [1] [2]These changes aim to enhance code maintainability and readability by consolidating path-related options and removing unnecessary complexity.
Relates to #45927