Reduce specific test executions times #48405
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the number of entries to reduce the runtime as these two tests were at 10 minutes and 3 minutes respectively
…ts were going over 1 minute. Because of how we split up tests, even a few longer tests with a lots of params can extend a test leg.
ghost
added
This was referenced Apr 12, 2025
Forgind
reviewed
Apr 22, 2025
test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs
Show resolved
Hide resolved
Forgind
approved these changes
Apr 30, 2025
test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs
Show resolved
Hide resolved
agocke
reviewed
May 3, 2025
| @@ -96,7 +96,7 @@ public void ILLink_runs_and_creates_linked_app(string targetFramework, bool refe | |||
| } | |||
|
|
|||
| [RequiresMSBuildVersionTheory("17.0.0.32901")] | |||
| [MemberData(nameof(SupportedTfms), MemberType = typeof(PublishTestUtils))] | |||
| [MemberData(nameof(Net8Plus), MemberType = typeof(PublishTestUtils))] | |||
There was a problem hiding this comment.
Maybe just remove the unsupported TFMs from SupportedTfms?
There was a problem hiding this comment.
@agocke I interpreted "SupprotedTfms" as being supported for the feature, not in support as it goes back to netcoreapp3.1 and has been for a while. These are your tests so happy to change what supported means here to be the same as net8plus for the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a PR that splits tests by individual test rather than test class to help identify the slowest tests. There were two test work items that ran significantly longer than all others at 28m and 22m (next closest was 15m). Running the tests I identified some optimizations to make in the nuget tests and reduced matrix for the illink tests.
#44898 (comment)
For the nuget tests, I did two things:
For the ILLink tests, I just took any test that took over 50s and made it target net8+ since the others are no longer in support.