Skip to content

Reenable CheckTargetFrameworkDisplayName test #48471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: release/9.0.2xx
Choose a base branch
from

Conversation

v-wuzhai
Copy link
Member

@v-wuzhai v-wuzhai commented Apr 15, 2025

Fixed #45148

When using the dotnet run command to execute the project, the standard output is processed by StripTerminalLoggerProgressIndicators. This step can clean up progress indicators from the output but might also affect the format and content of the output. By using the dotnet exec command to directly execute the built DLL, the standard output is compared directly to the expected framework display name.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Apr 15, 2025
@v-wuzhai v-wuzhai requested a review from marcpopMSFT April 15, 2025 08:44
@v-wuzhai v-wuzhai marked this pull request as ready for review April 15, 2025 08:44
@marcpopMSFT
Copy link
Member

Would an alternative fix here be to keep run but use the /tl:off flag? @baronfel any changes coming that auto-detect this or change the default for run?

@v-wuzhai
Copy link
Member Author

v-wuzhai commented Apr 16, 2025

Can try using /tl:off, but considering the issue PR mentioned that StripTerminalLoggerProgressIndicators might be unreliable, I prefer to maintain the original changes.

This reverts commit ac6f46a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants