Skip to content

Include the SDK tarball in poison checks #48550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+712 −6
Open

Include the SDK tarball in poison checks #48550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec7d0ac
Include SDK in poison checks
NikolaMilosavljevic Apr 17, 2025
3cd22d9
Follow up
NikolaMilosavljevic Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/SourceBuild/content/eng/finish-source-only.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,25 +124,25 @@
<UsingTask TaskName="Microsoft.DotNet.SourceBuild.Tasks.LeakDetection.CheckForPoison" AssemblyFile="$(MicrosoftDotNetSourceBuildTasksLeakDetectionAssembly)" TaskFactory="TaskHostFactory" Condition="'$(EnablePoison)' == 'true'" />
<Target Name="ReportPoisonUsage"
BeforeTargets="Build"
DependsOnTargets="CopySdkArchive"
Condition="'$(EnablePoison)' == 'true'"
Inputs="$(MSBuildProjectFullPath)"
Outputs="$(BaseIntermediateOutputPath)ReportPoisonUsage.complete" >
<ItemGroup>
<!-- Exclude the Private.SourceBuilt.Artifacts archive from poison usage scan. -->
<AssetToCheck Include="$(ArtifactsAssetsDir)*$(ArchiveExtension)" />
<AssetToCheck Remove="$(ArtifactsAssetsDir)$(SourceBuiltArtifactsTarballName)*" />
<!-- Include dotnet-sdk-*.tar.gz -->
<SdkArchive Include="$(ArtifactsAssetsDir)dotnet-sdk-*$(ArchiveExtension)" />
<!-- Include shipping nuget packages. -->
<ShippingPackageToCheck Include="$(ArtifactsShippingPackagesDir)**/*.nupkg" />
<!-- Add and mark SBRP packages to validate that they have the correct poison attribute. -->
<SbrpPackageToCheck Include="$(ReferencePackagesDir)**\*.nupkg" IsSourceBuildReferencePackage="true" />
</ItemGroup>

<Error Condition="'@(AssetToCheck)' == ''" Text="No assets will be poison checked - this is unexpected!" />
<Error Condition="'@(SdkArchive)' == ''" Text="SDK archive will not be poison checked - this is unexpected!" />
<Error Condition="'@(ShippingPackageToCheck)' == ''" Text="No shipping packages will be poison checked - this is unexpected!" />
<Error Condition="'@(SbrpPackageToCheck)' == ''" Text="No SBRP packages will be poison checked - this is unexpected!" />

<ItemGroup>
<PoisonFileToCheck Include="@(AssetToCheck)" />
<PoisonFileToCheck Include="@(SdkArchive)" />
<PoisonFileToCheck Include="@(ShippingPackageToCheck)" />
<PoisonFileToCheck Include="@(SbrpPackageToCheck)" />
</ItemGroup>
Expand Down
Loading
Loading