Remove analyzer redirecting DLL #51511
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjonescz
requested review from
333fred,
JoeRobich,
MiYanni,
RikkiGibson,
Copilot and
jaredpar
There was a problem hiding this comment.
Pull Request Overview
This PR removes the Microsoft.Net.Sdk.AnalyzerRedirecting project and its associated infrastructure from the SDK repository. The analyzer redirecting functionality (which prevents the "torn SDK" issue) is being moved from the SDK to Roslyn, as Roslyn already has a VSIX deployment mechanism.
Key changes:
- Removed the entire
Microsoft.Net.Sdk.AnalyzerRedirectingsource project and test project - Updated the documentation to reflect that Roslyn will now deploy the
IAnalyzerAssemblyRedirectorimplementation - Cleaned up build scripts and solution files to remove references to the deleted projects
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
test/UnitTests.proj |
Removed conditional test inclusion for AnalyzerRedirecting.Tests |
test/Microsoft.Net.Sdk.AnalyzerRedirecting.Tests/SdkAnalyzerAssemblyRedirectorTests.cs |
Deleted test file |
test/Microsoft.Net.Sdk.AnalyzerRedirecting.Tests/Microsoft.Net.Sdk.AnalyzerRedirecting.Tests.csproj |
Deleted test project |
src/Tasks/sdk-tasks/GenerateRuntimeAnalyzersSWR.cs |
Removed AnalyzerRedirecting folder from deployment |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/source.extension.vsixmanifest |
Deleted VSIX manifest |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/SdkAnalyzerAssemblyRedirector.cs |
Deleted redirector implementation |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/Microsoft.Net.Sdk.AnalyzerRedirecting.csproj |
Deleted project file |
src/Microsoft.Net.Sdk.AnalyzerRedirecting/AnalyzerRedirectingPackage.cs |
Deleted VS package file |
src/Layout/VS.Redist.Common.Net.Core.SDK.RuntimeAnalyzers/VS.Redist.Common.Net.Core.SDK.RuntimeAnalyzers.proj |
Removed project reference and build steps for AnalyzerRedirecting |
sdk.slnx |
Removed project references from solution |
documentation/general/analyzer-redirecting.md |
Updated documentation to reflect that Roslyn now deploys the redirector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #42861.
Moving analyzer redirecting DLL to Roslyn: dotnet/roslyn#80969