Update runtime dependencies to v10.0.102 #52721
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the SDK repo’s runtime/VMR dependency pins to align with the dotnet/dotnet v10.0.102 build.
Changes:
- Bumps dotnet-dotnet (VMR-produced) dependency versions/SHA pins to
10.0.2/10.0.102and new commit445250…ineng/Version.Details.xml. - Updates the corresponding MSBuild property versions in
eng/Version.Details.props. - Removes dotnet-dotnet DARC package sources from
NuGet.configand adds a runtime update plan prompt document under.github/prompts/.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/Version.Details.xml | Updates dotnet-dotnet dependency versions and SHAs to the new VMR/runtime set. |
| eng/Version.Details.props | Keeps the MSBuild property version pins in sync with updated dependency versions. |
| NuGet.config | Removes dotnet-dotnet DARC package sources (potentially impacting restore depending on feed availability). |
| .github/prompts/runtime-version-update-plan.md | Adds a documented plan for performing runtime dependency updates using DARC. |
| <!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.--> | ||
| <!-- Begin: Package sources from dotnet-dotnet --> | ||
| <add key="darc-pub-dotnet-dotnet-fad253f" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-dotnet-fad253f5/nuget/v3/index.json" /> | ||
| <add key="darc-int-dotnet-dotnet-fad253f" value="https://pkgs.dev.azure.com/dnceng/internal/_packaging/darc-int-dotnet-dotnet-fad253f5/nuget/v3/index.json" /> | ||
| <!-- End: Package sources from dotnet-dotnet --> |
There was a problem hiding this comment.
The dotnet-dotnet DARC package sources were removed, leaving the "Package sources from dotnet-dotnet" section empty. Since this PR updates many dependencies to new dotnet-dotnet-produced versions (eng/Version.Details.xml now points at Sha 4452502459...), restore may no longer be able to resolve those packages unless they’re available from the remaining feeds. Either add the corresponding darc-pub/darc-int sources for the new dotnet-dotnet commit, or verify and document that all required packages are now served from the existing dotnet10/dotnet-public feeds and the DARC sources are intentionally no longer needed.
| ```bash | ||
| # Using git to get the commit for a tag | ||
| git ls-remote https://github.com/dotnet/dotnet refs/tags/v10.0.102 | ||
|
|
||
| # Or if you have the repo cloned: | ||
| git rev-parse v10.0.102^{commit} | ||
| ``` |
There was a problem hiding this comment.
Step 1’s git ls-remote ... refs/tags/v10.0.102 can return the tag object SHA for annotated tags, not the commit SHA. Use the dereferenced ref (e.g., refs/tags/v10.0.102^{}) or otherwise ensure you resolve to the commit SHA before passing it to darc get-build.
| ### Step 4: Run update-dependencies for the target version | ||
|
|
||
| ```bash | ||
| darc update-dependencies --id <bar-id-from-step-2> |
There was a problem hiding this comment.
Could you use the --source-repo option instead? Based on the description, it seems like this is what you'd want to use, targeting both https://dev.azure.com/dnceng/internal/_git/dotnet-dotnet and https://github.com/dotnet/dotnet.
Created using copilot CLI using the plan included in this PR. I believe tooling is being worked on to do this for us but figured this is a reasonable stop-gap.
CC @mmitche to see the .md file I used.