Pin hot reaload wasm browser package version #52733
Open
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
the
Area-AspNetCore
Contributor
|
Thanks for your PR, @@ilonatommy. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds .NET 11.0 target framework support for the HotReload WebAssembly Browser package to fix a missing package version issue when building .NET 11 WebAssembly applications.
Changes:
- Added
AgentTargetFrameworkV11property for .NET 11.0 assemblies injected into apps - Updated WebAssembly.Browser project to multi-target both net10.0 and net11.0
- Clarified that
AgentTargetFrameworkV10is specifically for .NET 10.0 (not 10.0+)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/BuiltInTools/Watch/TargetFrameworks.props | Adds AgentTargetFrameworkV11 property and updates V10 comment to be more precise |
| src/BuiltInTools/HotReloadAgent.WebAssembly.Browser/Microsoft.DotNet.HotReload.WebAssembly.Browser.csproj | Imports TargetFrameworks.props and multi-targets net10.0 and net11.0 to ensure compatibility with both runtime versions |
tmat
requested changes
Jan 29, 2026
Member
tmat
left a comment
tmat
left a comment
There was a problem hiding this comment.
Do we actually need to target .NET 11? Wouldn't pinning to net10 work?
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #52517 but fixes dotnet/aspnetcore#65261.
Testing:
dotnet pack ".\src\BuiltInTools\HotReloadAgent.WebAssembly.Browser\Microsoft.DotNet.HotReload.WebAssembly.Browser.csproj" -c Debug -o ".\artifacts\packages\Debug\Shipping" /p:Version=11.0.100-preview.1.26078.107to create the missing net11 packageExpand-Archive -Path $nupkg -DestinationPath "C:\Nuget\microsoft.dotnet.hotreload.webassembly.browser\11.0.100-preview.1.26078.107" -Force