[WIP] [NO-REVIEW] [NO-MERGE] Remove VMR inner-build concept #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
force-pushed
the
RemoveInnerBuildConcept
branch
9 times, most recently
from
632b15f to
49725e3
Compare
ViktorHofer
force-pushed
the
RemoveInnerBuildConcept
branch
3 times, most recently
from
754095a to
28af55e
Compare
ViktorHofer
force-pushed
the
RemoveInnerBuildConcept
branch
16 times, most recently
from
a2c3bc4 to
609c8c6
Compare
ViktorHofer
force-pushed
the
RemoveInnerBuildConcept
branch
2 times, most recently
from
7cf6e3a to
84f2c79
Compare
ViktorHofer
force-pushed
the
RemoveInnerBuildConcept
branch
5 times, most recently
from
a819eb7 to
4fe8a4d
Compare
1. Remove the repo source-build infrastructure: - The outer/inner-build concept - The SB intermediate package creation 2. Remove the DotNetBuildPhase property and replace its usage with the now only two inclusive properties. Update docs. 3. Move the ArPow inner clone target into the VMR orchestrator and integrate it into the repo infra (still conditional only for SBE). 4. Move the ArPow target that handles creating the package usage data and the package report into the VMR orchestrator 5. Update the remaining DotNetBuild.props files with the new property, item and target names. Extra work: - Move the `WritePrebuiltUsageData` and `ReportPrebuiltUsage` targets that were executed only for dotnet.proj into finish-source-only.proj to better distinguish them from the newly added ArPow targets that got moved into the VMR orchestrator. - Place the "prebuilt-report" logs under "artifacts\log\<config>\" and avoid the now unnecessary copy step in the YML. - Remove unnecessary SourceBuild.props / DotNetBuild.props which only contained properties that were used for repo source-build. - Rename the remaining few SourceBuild.props to DotNetBuild.props
ViktorHofer
force-pushed
the
RemoveInnerBuildConcept
branch
from
4fe8a4d to
8f8492c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4249
Fixes dotnet/source-build#3789
Fixes dotnet/source-build#3807
Fixes dotnet/source-build#4184
Fixes dotnet/source-build#4444
Depends on dotnet/source-build#5006, dotnet/source-build#5034
Extra work for which I will submit separate PRs:
WritePrebuiltUsageDataandReportPrebuiltUsagetargets that were executed only for dotnet.proj into finish-source-only.proj to better distinguish them from the newly added ArPow targets that got moved into the VMR orchestrator.artifacts\log\<config>\and avoid the now unnecessary copy step in the YML.