Open
Conversation
Contributor
|
Can't |
Author
|
I pointed to the Microsoft style guide above - that's our official guideline. Also, if you look at the examples under computing in the Wikipedia article, they follow the same rules as I described. But it's up to you whether you wanna take this change or not. |
imback82
suggested changes
Dec 6, 2019
| @@ -147,7 +147,7 @@ object DotnetRunner extends Logging { | |||
| } else { | |||
| // scalastyle:off println | |||
| println("***********************************************************************") | |||
Contributor
There was a problem hiding this comment.
Can you update https://github.com/dotnet/spark/blob/master/src/scala/microsoft-spark-2.3.x/src/main/scala/org/apache/spark/deploy/dotnet/DotnetRunner.scala as well? That's causing the test failures.
Author
|
I rolled back some of the changes and kept only the ones in code comments and Markdown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in the docs that back end was misspelled. It's either two words or hyphened when used as an adjective: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/b/back-end
I've only changed text and comments, but not variable names.