Skip to content

Fix tasks not loading on .NET Framework #8952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged

Fix tasks not loading on .NET Framework #8952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f096ce9
Fix tasks not loading on .NET Framework
ViktorHofer Apr 16, 2025
6eb4aa1
Fix TFMs and set NetFrameworkMinimum to net472
ViktorHofer Apr 17, 2025
0de1f7f
Build NetCurrent in source-only builds
ViktorHofer Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@

<!-- Enable reproducible build per binskim -->
<Deterministic>true</Deterministic>

<!-- The minimum .NET Framework version supported by templating packages. -->
<NetFrameworkMinimum>net472</NetFrameworkMinimum>

<!-- Only build the latest .NETCoreApp TFM when building source-only. -->
<NetMinimum Condition="'$(DotNetBuildSourceOnly)' == 'true'">$(NetCurrent)</NetMinimum>
</PropertyGroup>

<ItemGroup Condition="'$(EnableAnalyzers)' == 'true'">
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.TemplateEngine.Abstractions/Microsoft.TemplateEngine.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(NetCurrent);netstandard2.0;$(NetFrameworkCurrent)</TargetFrameworks>
<TargetFrameworks>$(NetMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
<Description>Contracts for extending Template Engine</Description>
<IsPackable>true</IsPackable>
<EnablePublicApiAnalyzer>true</EnablePublicApiAnalyzer>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.TemplateEngine.Core.Contracts/Microsoft.TemplateEngine.Core.Contracts.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(NetCurrent);netstandard2.0;$(NetFrameworkCurrent)</TargetFrameworks>
<TargetFrameworks>$(NetMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
<Description>Contracts for extending Microsoft.TemplateEngine.Core</Description>
<IsPackable>true</IsPackable>
<EnablePublicApiAnalyzer>true</EnablePublicApiAnalyzer>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.TemplateEngine.Core/Microsoft.TemplateEngine.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(NetCurrent);netstandard2.0;$(NetFrameworkCurrent)</TargetFrameworks>
<TargetFrameworks>$(NetMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
<Description>Common operations for instantiating templates using forward-only input stream operations</Description>
<IsPackable>true</IsPackable>
<EnablePublicApiAnalyzer>true</EnablePublicApiAnalyzer>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.TemplateEngine.Edge/Microsoft.TemplateEngine.Edge.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(NetCurrent);netstandard2.0;$(NetFrameworkCurrent)</TargetFrameworks>
<TargetFrameworks>$(NetMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
<Description>Helper package for adding Template Engine to consuming applications</Description>
<IsPackable>true</IsPackable>
<EnablePublicApiAnalyzer>true</EnablePublicApiAnalyzer>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.TemplateEngine.IDE/Microsoft.TemplateEngine.IDE.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(NetCurrent);netstandard2.0;$(NetFrameworkCurrent)</TargetFrameworks>
<TargetFrameworks>$(NetMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
<Description>Helper package for adding Template Engine to IDEs</Description>
<IsPackable>true</IsPackable>
<EnablePublicApiAnalyzer>true</EnablePublicApiAnalyzer>
Expand Down
2 changes: 1 addition & 1 deletion ...chestrator.RunnableProjects/Microsoft.TemplateEngine.Orchestrator.RunnableProjects.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(NetCurrent);netstandard2.0;$(NetFrameworkCurrent)</TargetFrameworks>
<TargetFrameworks>$(NetMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
<Description>An extension for Template Engine that allows projects that still run to be used as templates</Description>
<IsPackable>true</IsPackable>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.TemplateEngine.Utils/Microsoft.TemplateEngine.Utils.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(NetCurrent);netstandard2.0;$(NetFrameworkCurrent)</TargetFrameworks>
<TargetFrameworks>$(NetMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
<Description>Components used by all Template Engine extensions and consumers</Description>
<IsPackable>true</IsPackable>
<EnablePublicApiAnalyzer>true</EnablePublicApiAnalyzer>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.TemplateSearch.Common/Microsoft.TemplateSearch.Common.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(NetCurrent);$(NetFrameworkCurrent)</TargetFrameworks>
<TargetFrameworks>$(NetMinimum);$(NetFrameworkMinimum)</TargetFrameworks>
<Description>Components used by the template discovery tool, and also used for related functionality in the CLI.</Description>
<IsPackable>true</IsPackable>
<EnablePublicApiAnalyzer>true</EnablePublicApiAnalyzer>
Expand Down
2 changes: 1 addition & 1 deletion test/Microsoft.TemplateEngine.TestHelper/Microsoft.TemplateEngine.TestHelper.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<!-- Don't set IsTestUtilityProject=true because this project is referenced by tools and would otherwise be filtered out. -->
<PropertyGroup>
<TargetFrameworks>$(NetCurrent);$(NetFrameworkCurrent)</TargetFrameworks>
<TargetFrameworks>$(NetMinimum);$(NetFrameworkMinimum)</TargetFrameworks>
<IsPackable>true</IsPackable>
<IsShipping>false</IsShipping>
<EnablePublicApiAnalyzer>true</EnablePublicApiAnalyzer>
Expand Down
3 changes: 2 additions & 1 deletion tools/Microsoft.TemplateEngine.Authoring.CLI/Microsoft.TemplateEngine.Authoring.CLI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>$(NetCurrent)</TargetFramework>
<TargetFramework>$(NetMinimum)</TargetFramework>
<Description>A dotnet CLI tool with commands for template authoring.</Description>
<IsPackable>true</IsPackable>
<PackAsTool>true</PackAsTool>
<ToolCommandName>dotnet-template-authoring</ToolCommandName>
<RollForward>Major</RollForward>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...thoring.TemplateApiVerifier/Microsoft.TemplateEngine.Authoring.TemplateApiVerifier.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>$(NetCurrent)</TargetFramework>
<TargetFramework>$(NetMinimum)</TargetFramework>
<Description>The extension of templates verification engine enabling verification testing through dotnet template engine API.</Description>
<EnablePublicApiAnalyzer>true</EnablePublicApiAnalyzer>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
Expand Down
2 changes: 1 addition & 1 deletion ...ine.Authoring.TemplateVerifier/Microsoft.TemplateEngine.Authoring.TemplateVerifier.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>$(NetCurrent)</TargetFramework>
<TargetFramework>$(NetMinimum)</TargetFramework>
<Description>The verification engine for the templates for .NET template engine.</Description>
<IsPackable>true</IsPackable>
<EnablePublicApiAnalyzer>true</EnablePublicApiAnalyzer>
Expand Down
2 changes: 1 addition & 1 deletion ...plateEngine.TemplateLocalizer.Core/Microsoft.TemplateEngine.TemplateLocalizer.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(NetCurrent);netstandard2.0;$(NetFrameworkCurrent)</TargetFrameworks>
<TargetFrameworks>$(NetMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
<Description>The core API for Template Localizer tool.</Description>
<IsPackable>true</IsPackable>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
2 changes: 1 addition & 1 deletion ...rosoft.TemplateSearch.TemplateDiscovery/Microsoft.TemplateSearch.TemplateDiscovery.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>$(NetCurrent)</TargetFramework>
<TargetFramework>$(NetMinimum)</TargetFramework>
<OutputType>Exe</OutputType>
<IsPackable>true</IsPackable>
<IsShipping>false</IsShipping>
Expand Down
Loading