Skip to content

Commit

Permalink
Fixes misleading error message (#12826)
Browse files Browse the repository at this point in the history
Updated the resource string to replace "field" with "property" as suggested, ensuring it reflects the correct value.

Fixes #12810

- The original resource file used the term "field" instead of "property," which caused confusion in the context where we were searching for a property with a given name.

- Updated the resource string to replace "field" with "property" as suggested, ensuring it reflects the correct value.


Co-authored-by: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) <[email protected]>
  • Loading branch information
ricardobossan and Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box) authored Jan 24, 2025
1 parent 5fc66aa commit 99d66e1
Show file tree
Hide file tree
Showing 15 changed files with 69 additions and 69 deletions.
4 changes: 2 additions & 2 deletions src/System.Windows.Forms/src/Resources/SR.resx
Original file line number Diff line number Diff line change
Expand Up @@ -2367,8 +2367,8 @@ To replace this default dialog please handle the DataError event.</value>
<data name="DataGridViewComboBoxCell_DropDownWidthOutOfRange" xml:space="preserve">
<value>DropDownWidth value cannot be smaller than {0}.</value>
</data>
<data name="DataGridViewComboBoxCell_FieldNotFound" xml:space="preserve">
<value>Field called {0} does not exist.</value>
<data name="DataGridViewComboBoxCell_PropertyNotFound" xml:space="preserve">
<value>Property called {0} does not exist.</value>
</data>
<data name="DataGridViewComboBoxCell_InvalidValue" xml:space="preserve">
<value>DataGridViewComboBoxCell value is not valid.</value>
Expand Down
10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.ja.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.ko.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.pl.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.pt-BR.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.ru.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.tr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.zh-Hans.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/System.Windows.Forms/src/Resources/xlf/SR.zh-Hant.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -1359,7 +1359,7 @@ private void InitializeDisplayMemberPropertyDescriptor(string? displayMember)
PropertyDescriptor? displayMemberProperty = props.Find(displayBindingMember.BindingField, true);
if (displayMemberProperty is null)
{
throw new ArgumentException(string.Format(SR.DataGridViewComboBoxCell_FieldNotFound, displayMember));
throw new ArgumentException(string.Format(SR.DataGridViewComboBoxCell_PropertyNotFound, displayMember));
}
else
{
Expand Down Expand Up @@ -1390,7 +1390,7 @@ private void InitializeValueMemberPropertyDescriptor(string? valueMember)
PropertyDescriptor? valueMemberProperty = props.Find(valueBindingMember.BindingField, true);
if (valueMemberProperty is null)
{
throw new ArgumentException(string.Format(SR.DataGridViewComboBoxCell_FieldNotFound, valueMember));
throw new ArgumentException(string.Format(SR.DataGridViewComboBoxCell_PropertyNotFound, valueMember));
}
else
{
Expand Down

0 comments on commit 99d66e1

Please sign in to comment.