Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent exception when creating a ListViewGroupAccessibleObject #10934

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ internal IReadOnlyList<ListViewGroup> GetVisibleGroups()
IReadOnlyList<ListViewGroup> visibleGroups = GetVisibleGroups();
for (int i = 0; i < visibleGroups.Count; i++)
{
if (visibleGroups[i].AccessibilityObject.Bounds.Contains(hitTestPoint))
if (visibleGroups[i].AccessibilityObject?.Bounds.Contains(hitTestPoint) == true)
{
return visibleGroups[i].AccessibilityObject;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,12 @@ internal sealed class ListViewGroupAccessibleObject : AccessibleObject
private readonly ListViewGroup _owningGroup;
private readonly bool _owningGroupIsDefault;

public ListViewGroupAccessibleObject(ListViewGroup owningGroup, bool owningGroupIsDefault)
public ListViewGroupAccessibleObject(ListViewGroup owningGroup, ListView listView, bool owningGroupIsDefault)
{
_owningGroup = owningGroup.OrThrowIfNull();
_owningListView = listView.OrThrowIfNull();

// Using item from group for getting of ListView is a workaround for https://github.com/dotnet/winforms/issues/4019
_owningListView = owningGroup.ListView
?? (owningGroup.Items.Count > 0 && _owningGroup.Items[0].ListView is ListView listView
? listView
: throw new InvalidOperationException(nameof(owningGroup.ListView)));

_owningListViewAccessibilityObject = _owningListView.AccessibilityObject as ListView.ListViewAccessibleObject
_owningListViewAccessibilityObject = _owningListView.AccessibilityObject as ListViewAccessibleObject
?? throw new InvalidOperationException(nameof(_owningListView.AccessibilityObject));

_owningGroupIsDefault = owningGroupIsDefault;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,26 @@ public ListViewGroup(string? header, HorizontalAlignment headerAlignment) : this
_headerAlignment = headerAlignment;
}

internal AccessibleObject AccessibilityObject
=> _accessibilityObject ??= new ListViewGroupAccessibleObject(this, ListView?.Groups.Contains(this) == false);
internal AccessibleObject? AccessibilityObject
{
get
{
if (_accessibilityObject is not null)
{
return _accessibilityObject;
}

// Using item from group for getting of ListView is a workaround for https://github.com/dotnet/winforms/issues/4019
var listView = ListView;
listView ??= Items.Count > 0 ? Items[0].ListView : null;
if (listView is not null)
{
_accessibilityObject = new ListViewGroupAccessibleObject(this, listView, owningGroupIsDefault: !listView.Groups.Contains(this));
}

return _accessibilityObject;
}
}

/// <summary>
/// The text displayed in the group header.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1326,10 +1326,12 @@ public void ListViewGroupAccessibleObject_IsPatternSupported_ReturnFalse_ForColl
};

listView.Groups.Add(listGroup);
ListViewItem item = new("Test");
item.Group = listGroup;
ListViewItem item = new("Test")
{
Group = listGroup
};
listView.Items.Add(item);
ListViewGroupAccessibleObject accessibleObject = new(listGroup, false);
ListViewGroupAccessibleObject accessibleObject = new(listGroup, listView, false);

if (createHandle)
{
Expand Down
Loading