Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage for DownloadFile Review 1St #12486

Open
wants to merge 104 commits into
base: main
Choose a base branch
from

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Nov 14, 2024

Replace corrupt PR12221

Proposed changes

  • Code Coverage for DownloadFile

Customer Impact

  • This adds code coverage for DownloadFile which will be required to replace obsolete WebClient.

Regression?

  • No

Risk

-None

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

@paul1956 paul1956 requested a review from a team as a code owner November 14, 2024 19:22
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.82980%. Comparing base (b295ae6) to head (2465ab0).
Report is 10 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b295ae6) and HEAD (2465ab0). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b295ae6) HEAD (2465ab0)
Debug 3 2
test 1 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12486          +/-   ##
====================================================
- Coverage   61.32242%   39.82980%   -21.49263%     
====================================================
  Files           1546        1018         -528     
  Lines         158407       96360       -62047     
  Branches       14748       13443        -1305     
====================================================
- Hits           97139       38380       -58759     
+ Misses         60571       57583        -2988     
+ Partials         697         397         -300     
Flag Coverage Δ
Debug 39.82980% <ø> (-21.49263%) ⬇️
integration 10.72419% <ø> (-0.00836%) ⬇️
production 39.82980% <ø> (+0.62888%) ⬆️
test ?
unit 37.25716% <ø> (+0.63199%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Improve code coverage for upload tests
Support more real File Server  options
…internal implementation. Use TypeResolver to load SystemConfiguration and add sample configuration for real servers. Add tests for leading ServerConfiguration json files.
Improve coverage
Fix cancelation logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants