-
Notifications
You must be signed in to change notification settings - Fork 1k
Removing assertion from constructor EditorServiceContext and update test "InvokeItemsDialog_ShouldThrowException" #13140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing assertion from constructor EditorServiceContext and update test "InvokeItemsDialog_ShouldThrowException" #13140
Conversation
…est "InvokeItemsDialog_ShouldThrowException"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13140 +/- ##
===================================================
+ Coverage 61.35965% 61.83600% +0.47634%
===================================================
Files 1547 1552 +5
Lines 158482 158943 +461
Branches 14752 14802 +50
===================================================
+ Hits 97244 98284 +1040
+ Misses 60536 59923 -613
- Partials 702 736 +34
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
...orms.Design/tests/UnitTests/System/Windows/Forms/Design/ListControlUnboundActionListTests.cs
Outdated
Show resolved
Hide resolved
...orms.Design/tests/UnitTests/System/Windows/Forms/Design/ListControlUnboundActionListTests.cs
Outdated
Show resolved
Hide resolved
… to UI Integration Tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I added some minor comments.
src/test/integration/UIIntegrationTests/ListControlUnboundActionListTests.cs
Outdated
Show resolved
Hide resolved
src/test/integration/UIIntegrationTests/ListControlUnboundActionListTests.cs
Outdated
Show resolved
Hide resolved
src/test/integration/UIIntegrationTests/ListControlUnboundActionListTests.cs
Outdated
Show resolved
Hide resolved
…sk waiting time and add retry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but task continuations should return to the same thread.
src/test/integration/UIIntegrationTests/ListControlUnboundActionListTests.cs
Outdated
Show resolved
Hide resolved
src/test/integration/UIIntegrationTests/ListControlUnboundActionListTests.cs
Outdated
Show resolved
Hide resolved
src/test/integration/UIIntegrationTests/ListControlUnboundActionListTests.cs
Outdated
Show resolved
Hide resolved
src/test/integration/UIIntegrationTests/ListControlUnboundActionListTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixed #13225
Proposed changes
InvokeItemsDialog_ShouldThrowException
Microsoft Reviewers: Open in CodeFlow