Removing assertion from constructor EditorServiceContext and update test "InvokeItemsDialog_ShouldThrowException" #13140
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est "InvokeItemsDialog_ShouldThrowException"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13140 +/- ##
===================================================
- Coverage 61.35965% 61.35120% -0.00846%
===================================================
Files 1547 1547
Lines 158482 158481 -1
Branches 14752 14752
===================================================
- Hits 97244 97230 -14
- Misses 60536 60548 +12
- Partials 702 703 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| @@ -44,6 +44,6 @@ public void GetSortedActionItems_ShouldReturnCorrectItems() | |||
| public void InvokeItemsDialog_ShouldThrowException() | |||
| { | |||
| Action action = _actionList.InvokeItemsDialog; | |||
| action.Should().Throw<Exception>(); | |||
| action.Should().Throw<NullReferenceException>(); | |||
There was a problem hiding this comment.
We should use a real component that had "Items" property instead of a mock so that we have a valid property descriptor.
The debug.Assert is completely valid and we should keep it for debugging.
Tanya-Solyanik
added
the
waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removing assertion from constructor
EditorServiceContextand update testInvokeItemsDialog_ShouldThrowExceptionFix for test failures like this one
Need PropertyDescriptor for ICollection property to associate collection editor with.
at System.Windows.Forms.Design.EditorServiceContext..ctor(ComponentDesigner designer, PropertyDescriptor prop) in //src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/EditorServiceContext.cs:line 34
at System.Windows.Forms.Design.EditorServiceContext.EditValue(ComponentDesigner designer, Object objectToChange, String propName) in //src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/EditorServiceContext.cs:line 48
at System.Windows.Forms.Design.ListControlUnboundActionList.InvokeItemsDialog() in //src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ListControlUnboundActionList.cs:line 20
at FluentAssertions.Specialized.ActionAssertions.InvokeSubject()
at FluentAssertions.Specialized.DelegateAssertions
2.InvokeSubjectWithInterception() at FluentAssertions.Specialized.DelegateAssertions2.Throw[TException](String because, Object[] becauseArgs)at System.Windows.Forms.Design.Tests.ListControlUnboundActionListTests.InvokeItemsDialog_ShouldThrowException() in //src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListControlUnboundActionListTests.cs:line 49
Microsoft Reviewers: Open in CodeFlow