Skip to content

Removing assertion from constructor EditorServiceContext and update test "InvokeItemsDialog_ShouldThrowException" #13140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Mar 14, 2025

Fixed #13225

Proposed changes

  • Update test InvokeItemsDialog_ShouldThrowException
Microsoft Reviewers: Open in CodeFlow

…est "InvokeItemsDialog_ShouldThrowException"
@LeafShi1 LeafShi1 requested a review from a team as a code owner March 14, 2025 08:46
@LeafShi1 LeafShi1 marked this pull request as draft March 14, 2025 08:47
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.83600%. Comparing base (3ec6746) to head (a3af152).
Report is 108 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13140         +/-   ##
===================================================
+ Coverage   61.35965%   61.83600%   +0.47634%     
===================================================
  Files           1547        1552          +5     
  Lines         158482      158943        +461     
  Branches       14752       14802         +50     
===================================================
+ Hits           97244       98284       +1040     
+ Misses         60536       59923        -613     
- Partials         702         736         +34     
Flag Coverage Δ
Debug 61.83600% <ø> (-6.40649%) ⬇️
integration 11.29118% <ø> (-5.08934%) ⬇️
production 39.88735% <ø> (-28.35514%) ⬇️
test 95.66990% <ø> (∅)
unit 37.22563% <ø> (-30.23863%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Mar 14, 2025
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Mar 14, 2025
@LeafShi1 LeafShi1 marked this pull request as ready for review March 19, 2025 00:45
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Mar 19, 2025
@LeafShi1 LeafShi1 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Mar 24, 2025
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback and removed waiting-review This item is waiting on review by one or more members of team labels Mar 25, 2025
@LeafShi1 LeafShi1 added the waiting-review This item is waiting on review by one or more members of team label Apr 2, 2025
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added some minor comments.

@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Apr 3, 2025
@LeafShi1 LeafShi1 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Apr 7, 2025
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but task continuations should return to the same thread.

@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback and removed waiting-review This item is waiting on review by one or more members of team labels Apr 7, 2025
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Apr 8, 2025
@LeafShi1 LeafShi1 merged commit ff73bfe into dotnet:main Apr 9, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview4 milestone Apr 9, 2025
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Apr 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the test case "InvokeItemsDialog_ShouldThrowException“
2 participants