Removing assertion from constructor EditorServiceContext and update test "InvokeItemsDialog_ShouldThrowException" #13140
+2
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removing assertion from constructor
EditorServiceContext
and update testInvokeItemsDialog_ShouldThrowException
Fix for test failures like this one
Need PropertyDescriptor for ICollection property to associate collection editor with.
at System.Windows.Forms.Design.EditorServiceContext..ctor(ComponentDesigner designer, PropertyDescriptor prop) in //src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/EditorServiceContext.cs:line 34
at System.Windows.Forms.Design.EditorServiceContext.EditValue(ComponentDesigner designer, Object objectToChange, String propName) in //src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/EditorServiceContext.cs:line 48
at System.Windows.Forms.Design.ListControlUnboundActionList.InvokeItemsDialog() in //src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ListControlUnboundActionList.cs:line 20
at FluentAssertions.Specialized.ActionAssertions.InvokeSubject()
at FluentAssertions.Specialized.DelegateAssertions
2.InvokeSubjectWithInterception() at FluentAssertions.Specialized.DelegateAssertions
2.Throw[TException](String because, Object[] becauseArgs)at System.Windows.Forms.Design.Tests.ListControlUnboundActionListTests.InvokeItemsDialog_ShouldThrowException() in //src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListControlUnboundActionListTests.cs:line 49
Microsoft Reviewers: Open in CodeFlow