Improve UIA Provider Cleanup Logic for Virtual ListView Items #13953
+35
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13922
Root Cause
When
ListView.VirtualMode = true
, the current implementation ofReleaseUiaProvider()
iterates over all indices (Items.Count) and callsItems.GetItemByIndex()
.This triggers
OnRetrieveVirtualItem
for every index, forcing creation of all virtual items even if they were never displayed or accessed.Result in:
Severe performance degradation for large virtual lists (e.g., tens of thousands of items).
High memory pressure due to unnecessary ListViewItem instantiation.
UI freeze during control disposal.
Proposed changes
This PR improves the cleanup logic for UI Automation (UIA) providers in ListView when operating in VirtualMode = true. Specifically:
Customer Impact
Regression?
Risk
Screenshots
Before
When closing the form containing the ListView (in virtual mode), followed by closing the main form, the application experienced a noticeable delay.
BeforeChanges.mp4
After
When closing the form containing the ListView (in virtual mode), and subsequently closing the main form, the main form closes immediately with no noticeable delay.
AfterChanges.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow