Skip to content

Fix MaskedTextBox PropertyGrid text editor DPI scaling at runtime #14166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −2
Open

Fix MaskedTextBox PropertyGrid text editor DPI scaling at runtime #14166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3753bf
Initial plan
Copilot Dec 24, 2025
9d86e02
Fix MaskedTextBox text editor DPI scaling issue
Copilot Dec 24, 2025
62a08d4
Add missing references
Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...m.Windows.Forms.Design/src/System/Windows/Forms/Design/MaskedTextBoxTextEditorDropDown.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ public MaskedTextBoxTextEditorDropDown(MaskedTextBox maskedTextBox)
BackColor = Drawing.SystemColors.Control;
BorderStyle = BorderStyle.FixedSingle;
Name = "MaskedTextBoxTextEditorDropDown";
Padding = new Padding(16);
Size = new Drawing.Size(100, 52);
Padding = new Padding(LogicalToDeviceUnits(16));
Size = LogicalToDeviceUnits(new Drawing.Size(100, 52));
((System.ComponentModel.ISupportInitialize)(_errorProvider)).EndInit();
ResumeLayout(false);
PerformLayout();
Expand Down
18 changes: 18 additions & 0 deletions ...esign/tests/UnitTests/System/Windows/Forms/Design/MaskedTextBoxTextEditorDropDownTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Drawing;

namespace System.Windows.Forms.Design.Tests;

public class MaskedTextBoxTextEditorDropDownTests
Expand Down Expand Up @@ -54,4 +56,20 @@ public void MaskInputRejected_SetsError_WhenInputRejected()
dropDownMaskedTextBox.Text = "invalid";
errorProvider.GetError(dropDownMaskedTextBox).Should().Contain(SR.MaskedTextBoxHintDigitExpected);
}

[Fact]
public void DropDown_SizeAndPadding_ScalesWithDPI()
{
using MaskedTextBox maskedTextBox = new();
using MaskedTextBoxTextEditorDropDown dropDown = new(maskedTextBox);

// The size and padding should be scaled based on DPI
// At 96 DPI (100%), Size should be (100, 52) and Padding should be (16, 16, 16, 16)
// At higher DPI, these values should scale proportionally
Size expectedSize = dropDown.LogicalToDeviceUnits(new Size(100, 52));
Padding expectedPadding = new(dropDown.LogicalToDeviceUnits(16));

dropDown.Size.Should().Be(expectedSize);
dropDown.Padding.Should().Be(expectedPadding);
}
}