Skip to content

Issue 14204 fix data grid view excessive cpu+memory usage #14224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeafShi1 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Issue 14204 fix data grid view excessive cpu+memory usage #14224

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82287a3
Fix excessive CPU/memory usage when closing DataGridView with many rows
LeafShi1 Jan 16, 2026
dc60434
Fix DataGridView ReleaseUiaProvider performance for large datasets
LeafShi1 Jan 20, 2026
894a006
Add static for new method ReleaseRowUiaProviders
LeafShi1 Jan 21, 2026
6b9ef23
DataGridViewRowAccessibleObject.Navigate(Previous) — Switch to Visibl…
LeafShi1 Jan 23, 2026
25e89dc
Delete unused private member VisibleIndex
LeafShi1 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 29 additions & 8 deletions src/System.Windows.Forms/System/Windows/Forms/Controls/DataGridView/DataGridView.Methods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25593,6 +25593,23 @@ private void ReleaseMouse()
Capture = false;
}

private static void ReleaseRowUiaProviders(DataGridViewRow row)
{
if (!row.IsAccessibilityObjectCreated)
{
return;
}

DataGridViewCellCollection cells = row.Cells;
for (int cellIndex = 0; cellIndex < cells.Count; cellIndex++)
{
cells[cellIndex].ReleaseUiaProvider();
}

row.HeaderCell.ReleaseUiaProvider();
row.ReleaseUiaProvider();
}

internal override void ReleaseUiaProvider(HWND handle)
{
if (!IsAccessibilityObjectCreated)
Expand All @@ -25602,17 +25619,22 @@ internal override void ReleaseUiaProvider(HWND handle)

if (OsVersion.IsWindows8OrGreater())
{
foreach (DataGridViewRow row in Rows)
// Collect unique rows from SharedList using HashSet for deduplication.
// SharedList may have over several hundred thousand entries, but most point to the same shared row instances.
HashSet<DataGridViewRow> uniqueRows = [];
List<DataGridViewRow> sharedList = Rows.SharedList;
for (int i = 0; i < sharedList.Count; i++)
{
foreach (DataGridViewCell cell in row.Cells)
{
cell.ReleaseUiaProvider();
}
uniqueRows.Add(sharedList[i]);
}

row.HeaderCell.ReleaseUiaProvider();
row.ReleaseUiaProvider();
// Release UIA providers for unique rows
foreach (DataGridViewRow row in uniqueRows)
{
ReleaseRowUiaProviders(row);
}

// Release column header accessibility objects
foreach (DataGridViewColumn column in Columns)
{
column.HeaderCell.ReleaseUiaProvider();
Expand All @@ -25621,7 +25643,6 @@ internal override void ReleaseUiaProvider(HWND handle)
_editingPanel?.ReleaseUiaProvider(HWND.Null);
_editingPanelAccessibleObject = null;
_topLeftHeaderCell?.ReleaseUiaProvider();

if (AccessibilityObject is DataGridViewAccessibleObject accessibleObject)
{
accessibleObject.ReleaseChildUiaProviders();
Expand Down
16 changes: 14 additions & 2 deletions ....Windows.Forms/System/Windows/Forms/Controls/DataGridView/DataGridViewColumnCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,9 +1064,21 @@ internal void RemoveAtInternal(int index, bool force)

if (DataGridView.IsAccessibilityObjectCreated && OsVersion.IsWindows8OrGreater())
{
foreach (DataGridViewRow row in DataGridView.Rows)
// Collect unique rows from SharedList using HashSet for deduplication.
HashSet<DataGridViewRow> uniqueRows = [];
List<DataGridViewRow> sharedList = DataGridView.Rows.SharedList;
for (int i = 0; i < sharedList.Count; i++)
{
row.Cells[index].ReleaseUiaProvider();
uniqueRows.Add(sharedList[i]);
}

// Release UIA providers for the cell at the removed column index
foreach (DataGridViewRow row in uniqueRows)
{
if (row.IsAccessibilityObjectCreated)
{
row.Cells[index].ReleaseUiaProvider();
}
}

dataGridViewColumn.HeaderCell.ReleaseUiaProvider();
Expand Down
Loading