-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update the selected anchor color in Dark mode #14237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update the selected anchor color in Dark mode #14237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds dark mode detection for the selected anchor color in the AnchorEditor to improve visual distinction in dark mode. The change addresses issue #14235 where selected anchors were not correctly distinguished in dark mode.
Changes:
- Added conditional logic to use
SystemBrushes.ControlTextfor selected anchor color in dark mode instead ofSystemBrushes.ControlDark
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/AnchorEditor.AnchorUI.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/AnchorEditor.AnchorUI.cs
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14237 +/- ##
===================================================
+ Coverage 77.18007% 77.21533% +0.03525%
===================================================
Files 3279 3279
Lines 645129 645131 +2
Branches 47728 47729 +1
===================================================
+ Hits 497911 498140 +229
+ Misses 143538 143293 -245
- Partials 3680 3698 +18
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Fixes #14235
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow