Skip to content

Conversation

@LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Jan 22, 2026

Fixes #14235

Proposed changes

  • Add dark mode detection for the color of the selected Anchor attribute in the AnchorEditor.AnchorUI.cs

Customer Impact

  • In dark mode, the selected anchors in AnchorEditor are correctly distinguished.

Regression?

  • No

Risk

  • MInimal

Screenshots

Before

Image

After

image

Test methodology

  • Manually

Test environment(s)

  • .net 11.0.0-alpha.1.26055.11
Microsoft Reviewers: Open in CodeFlow

@LeafShi1 LeafShi1 requested a review from a team as a code owner January 22, 2026 09:42
@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label Jan 22, 2026
@LeafShi1 LeafShi1 requested a review from Copilot January 22, 2026 09:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds dark mode detection for the selected anchor color in the AnchorEditor to improve visual distinction in dark mode. The change addresses issue #14235 where selected anchors were not correctly distinguished in dark mode.

Changes:

  • Added conditional logic to use SystemBrushes.ControlText for selected anchor color in dark mode instead of SystemBrushes.ControlDark

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.21533%. Comparing base (9c45a8c) to head (2399b80).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #14237         +/-   ##
===================================================
+ Coverage   77.18007%   77.21533%   +0.03525%     
===================================================
  Files           3279        3279                 
  Lines         645129      645131          +2     
  Branches       47728       47729          +1     
===================================================
+ Hits          497911      498140        +229     
+ Misses        143538      143293        -245     
- Partials        3680        3698         +18     
Flag Coverage Δ
Debug 77.21533% <0.00000%> (+0.03525%) ⬆️
integration 19.06534% <0.00000%> (+0.08351%) ⬆️
production 52.13293% <0.00000%> (+0.07923%) ⬆️
test 97.40479% <ø> (ø)
unit 49.51043% <0.00000%> (+0.01738%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-DarkMode Issues relating to Dark Mode feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DarkMode] Anchor attribute selection is unclear in Dark Mode

1 participant