Test WiX 3 with pre-migration Arcade - #887
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7e395b65-e592-4d78-aa38-58dc5cedae7c
There was a problem hiding this comment.
Pull request overview
This PR adjusts the repository’s build/toolset inputs to exercise the legacy WiX 3 packaging path while using an older (“pre-migration”) Arcade SDK version.
Changes:
- Downgrade
Microsoft.DotNet.Arcade.Sdkversion used viaglobal.jsonmsbuild SDK resolution. - Update
eng/Version.Details.xmlto match the Arcade SDK version and SHA. - Flip
UseWixToolset3totrueineng/Versions.propsto force the WiX 3 code path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| global.json | Pins Microsoft.DotNet.Arcade.Sdk to an earlier beta to test pre-migration behavior. |
| eng/Versions.props | Forces legacy WiX 3 path selection via UseWixToolset3=true. |
| eng/Version.Details.xml | Aligns dependency metadata (version/SHA) for Arcade SDK with the new pin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
This is temporary for p7 until we have a longer term solution. |
joeloff
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com