Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few Clipboard tests #10507

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

JeremyKuhne
Copy link
Member

@JeremyKuhne JeremyKuhne commented Feb 26, 2025

Adds a few Clipboard tests. Based somewhat on WinForms unit tests.

WPF doesn't consistently swallow bad data on the clipboard. This is called out with comments and skips.

Change PresentationCore.Tests so it can use [WpfFact] and shared test code. Add reference to drawing extensions so Clipboard image tests can be run.

Microsoft Reviewers: Open in CodeFlow

Adds a few Clipboard tests. Based somewhat on WinForms unit tests.

WPF doesn't consistently swallow bad data on the clipboard. This is called out with comments and skips.

Change PresentationCore.Tests so it can use `[WpfFact]` and shared test code. Add reference to drawing extensions so Clipboard image tests can be run.
@JeremyKuhne JeremyKuhne requested review from a team as code owners February 26, 2025 03:15
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Feb 26, 2025
@ThomasGoulet73
Copy link
Contributor

@JeremyKuhne: Just a ping to let you know that the test failures in this PR were fixed in main, pulling main should fix the failures.

@JeremyKuhne
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 88.48921% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@009ae5a). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10507   +/-   ##
==========================================
  Coverage        ?   11.56778%           
==========================================
  Files           ?        3214           
  Lines           ?      648655           
  Branches        ?       71535           
==========================================
  Hits            ?       75035           
  Misses          ?      572457           
  Partials        ?        1163           
Flag Coverage Δ
Debug 11.56778% <88.48921%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants