Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Force an x64 runtime install #10525

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Feb 28, 2025

Backport of #10494 to main

Works around an issue where because WPF uses Platform globally as to mean the Target platform, and because this is a default property that arcade uses to install additional runtimes, arcade installs the arm64 runtime on an x64 machine, which breaks when we try to run msbuild in signing. It would also break things if we ever ran testing.

<PropertyGroup>
    <Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
    <Platform Condition="'$(Platform)' == ''">AnyCPU</Platform>
    <PlatformName Condition="'$(PlatformName)' == ''">$(Platform)</PlatformName>
  </PropertyGroup>
Microsoft Reviewers: Open in CodeFlow

@github-actions github-actions bot requested review from a team as code owners February 28, 2025 11:28
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.25440%. Comparing base (83241ee) to head (8f4f7d2).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10525         +/-   ##
===================================================
+ Coverage   11.10049%   11.25440%   +0.15390%     
===================================================
  Files           3215        3215                 
  Lines         648440      648440                 
  Branches       71528       71528                 
===================================================
+ Hits           71980       72978        +998     
+ Misses        575464      574368       -1096     
- Partials         996        1094         +98     
Flag Coverage Δ
Debug 11.25440% <ø> (+0.15390%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants