- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.2k
 
[MilCodeGen] Allow emitting empty-lines via NULL, including conditionals #10856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            h3xds1nz
  wants to merge
  109
  commits into
  dotnet:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
h3xds1nz:milcodegen-newline2
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           @dipeshmsft I've done mostly everything that I could find.  | 
    
          Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@                 Coverage Diff                 @@
##                main      #10856         +/-   ##
===================================================
- Coverage   13.48885%   13.47349%   -0.01536%     
===================================================
  Files           3317        3317                 
  Lines         664749      664913        +164     
  Branches       74643       74654         +11     
===================================================
- Hits           89667       89587         -80     
- Misses        572488      572727        +239     
- Partials        2594        2599          +5     
 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    Community Contribution
  A label for all community Contributions 
  
    PR
  metadata: Label to tag PRs, to facilitate with triage 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Supersedes #10762
Description
Removes most of the empty lines that are present due to generating methods returning
string.Emptyas they're not applicable and interpreter then just emitting empty lines by simply using a magic string fornullin the parser.The added whitespaces are mostly wanted (e.g. newline after '}' is something that's enforced by StyleCop).
The only changes that matter (all those files are at the bottom):
This allows for the NULL support
These are the templating changes (note that "WriteParse" has no real changes, its just a whitespace move).
Customer Impact
None, whitespace changes only.
Regression
No.
Testing
Local build.
Risk
None, there are only whitespace changes.
Microsoft Reviewers: Open in CodeFlow