Pass the HwndSource parameters directly#11124
Open
lindexi wants to merge 1 commit intodotnet:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the RegisterHwndForInput method by removing unnecessary casting from PresentationSource to HwndSource, since the caller already has an HwndSource instance.
- Removes unnecessary type casting in the RegisterHwndForInput method
- Changes the parameter type from PresentationSource to HwndSource to match actual usage
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The RegisterHwndForInput only be called by `HwndStylusInputProvider..ctor`. And the `HwndStylusInputProvider..ctor` will pass the `HwndSource source` to RegisterHwndForInput method. So that it unnecessary to use the PresentationSource in RegisterHwndForInput.
3d3c03e to
6e23ef8
Compare
himgoyalmicro
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The RegisterHwndForInput only be called by
HwndStylusInputProvider..ctor. And theHwndStylusInputProvider..ctorwill pass theHwndSource sourceto RegisterHwndForInput method. So that it unnecessary to use the PresentationSource in RegisterHwndForInput.wpf/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/InterOp/HwndStylusInputProvider.cs
Lines 27 to 45 in ee7cbb8
Customer Impact
None.
Regression
Testing
Only CI
Risk
Low. I do not change any behavior.
Microsoft Reviewers: Open in CodeFlow