Fix off-by-one in PriorityBinding.InitializeClone#11420
Open
smolchanovsky wants to merge 1 commit intodotnet:mainfrom
Open
Fix off-by-one in PriorityBinding.InitializeClone#11420smolchanovsky wants to merge 1 commit intodotnet:mainfrom
smolchanovsky wants to merge 1 commit intodotnet:mainfrom
Conversation
Index must be less than the size of _bindingCollection Fixes dotnet#11419
dotnet-policy-service
bot
added
PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index must be less than the size of _bindingCollection
Fixes #11419
Description
PriorityBinding.InitializeClonehas the same off-by-one bug that was fixed forMultiBindingin #3220 / #3221.The fix for
MultiBindingchangedi<=_bindingCollection.Counttoi<_bindingCollection.Count, but the identical bug inPriorityBindingwas not addressed.Customer Impact
Low - the
Clonemethod is internal. However, it may be called internally by WPF in certain scenariosRegression
No. This bug has existed since the code was written. The same bug in
MultiBindingwas fixed in #3221, butPriorityBindingwas not included in that fixTesting
Manual testing
Risk
Low - trivial change
Microsoft Reviewers: Open in CodeFlow