Skip to content

Use exception throw helper#2903

Merged
MihaZupan merged 39 commits intodotnet:mainfrom
WeihanLi:use-exception-throw-helper
Jul 22, 2025
Merged

Use exception throw helper#2903
MihaZupan merged 39 commits intodotnet:mainfrom
WeihanLi:use-exception-throw-helper

Conversation

@WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Jul 19, 2025

  • use ArgumentNullException.ThrowIfNull
  • use ArgumentException.ThrowIfNullOrEmpty

fixes #2902

Copilot AI and others added 14 commits July 19, 2025 04:07
Initial plan
0bb8823
@WeihanLi
Initial exploration and plan for modernizing exception patterns
efe54c6 
Co-authored-by: WeihanLi <7604648+WeihanLi@users.noreply.github.com>
@WeihanLi
Update core transform classes to use modern exception helpers
f74ca06 
Co-authored-by: WeihanLi <7604648+WeihanLi@users.noreply.github.com>
@WeihanLi
Update middleware and config classes to use modern exception helpers
4e6297b 
Co-authored-by: WeihanLi <7604648+WeihanLi@users.noreply.github.com>
@WeihanLi
Bulk update of exception patterns using automated script
f23e73a 
Co-authored-by: WeihanLi <7604648+WeihanLi@users.noreply.github.com>
@WeihanLi
Update remaining complex exception patterns manually
a1e0f88 
Co-authored-by: WeihanLi <7604648+WeihanLi@users.noreply.github.com>
@WeihanLi
Revert global.json SDK version to original state
770587c 
Co-authored-by: WeihanLi <7604648+WeihanLi@users.noreply.github.com>
@WeihanLi
Remove redundant discard assignments after ThrowIfNull calls
37b06df 
Co-authored-by: WeihanLi <7604648+WeihanLi@users.noreply.github.com>
@WeihanLi
Place null checks before assignments in WebSocketsTelemetryMiddleware
c0c34cc 
Co-authored-by: WeihanLi <7604648+WeihanLi@users.noreply.github.com>
@WeihanLi
Group null checks before assignments in IngressCache constructor
ea19a7f 
Co-authored-by: WeihanLi <7604648+WeihanLi@users.noreply.github.com>
@WeihanLi
Group null checks before assignments and remove unnecessary null prop…
807cf6b 
…agation

Co-authored-by: WeihanLi <7604648+WeihanLi@users.noreply.github.com>
@WeihanLi
Group null checks before assignments in constructor patterns
15347e2 
Co-authored-by: WeihanLi <7604648+WeihanLi@users.noreply.github.com>
@WeihanLi
Merge pull request #1 from WeihanLi/copilot/fix-22b218dd-f466-4c03-82…
cd29e51 
…d9-34eafffc39e2

Modernize exception handling patterns to use .NET helper methods
@WeihanLi
adopt more argument exception throw helper
a0b1337
@WeihanLi WeihanLi marked this pull request as draft July 19, 2025 17:06
@WeihanLi WeihanLi marked this pull request as ready for review July 19, 2025 17:35
MihaZupan
MihaZupan approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

WeihanLi and others added 10 commits July 22, 2025 21:17
@WeihanLi @MihaZupan
Update src/ReverseProxy/Delegation/HttpSysDelegator.cs
6f7a9fa 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Update src/TelemetryConsumption/EventListenerService.cs
1eef853 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Update src/ReverseProxy/Forwarder/HttpForwarder.cs
71e484b 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Update src/ReverseProxy/WebSocketsTelemetry/HttpUpgradeFeatureWrapper.cs
374b605 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Update src/ReverseProxy/WebSocketsTelemetry/HttpConnectFeatureWrapper.cs
7feba1c 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Update src/ReverseProxy/Utilities/ParsedMetadataEntry.cs
93444f1 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Update src/ReverseProxy/Transforms/PathTransformExtensions.cs
99cd18a 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
e44505a 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
8c56156 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
eddb232 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
WeihanLi and others added 14 commits July 22, 2025 21:54
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
3012010 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
a6fe6ec 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
cdca9ab 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
11d26c0 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
5112cce 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
153ee7f 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
c217983 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
433640e 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
144bd8f 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi @MihaZupan
Apply suggestion from @MihaZupan
26ed1fe 
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@WeihanLi
apply more suggestions
c19200b
@WeihanLi
refactor: apply suggestions for StreamCopyHttpContent
f0799f4
@WeihanLi
refactor: prefer ToArray directly according to the suggestion
28a87f9
@WeihanLi
refactor: align null check style for configChangeListeners
65ecbbd
@MihaZupan MihaZupan merged commit b8291f9 into dotnet:main Jul 22, 2025
7 checks passed
@MihaZupan MihaZupan mentioned this pull request Jul 22, 2025
Merged
@MihaZupan MihaZupan added this to the YARP 3.0 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

@benjaminpetit benjaminpetit Awaiting requested review from benjaminpetit benjaminpetit is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

YARP 3.0

Development

Successfully merging this pull request may close these issues.

Use exception throw helper

3 participants

@WeihanLi @MihaZupan